New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860296 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

USS bookmarks don't send specifics on deletion

Reported by ascheg...@yandex-team.ru, Jul 4

Issue description

Old bookmarks were sending specifics on deletion, as it was added in  crbug.com/365752  .

However USS bookmarks don't do that. (See https://cs.chromium.org/chromium/src/components/sync/engine_impl/non_blocking_type_commit_contribution.cc?q=non_blocking_type_commit_contribution.cc&sq=package:chromium&g=0&l=193 .)

Was it intentional or perhaps was it somehow forgotten?
 
Cc: mastiz@chromium.org
Owner: mamir@chromium.org
Status: Unconfirmed (was: New)
Thanks for keeping an eye on this, but it's a bit premature to file bugs until USS bookmarks is fully implemented (say, at least, until all integration tests have been enabled). In particular, local deletions are not yet implemented, so I'm wondering how you concluded there is a bug?

Furthermore, all USS types set up sufficient information for the server to know the datatype, as per https://cs.chromium.org/chromium/src/components/sync/engine_impl/non_blocking_type_commit_contribution.cc?l=226&rcl=ac6f267da8542f300d071cbaea765c94407d78f5

I'd be good to understand which fields you rely on server-side for tombstones: it feels like entity ID + datatype should suffice.
Labels: Needs-Feedback
ascheglov@: friendly ping for questions from #1.
We rely on the current behavior, i.e. when the client sends full specifics for deleted bookmarks.  
So we're concerned whether the client would change its behavior when USS bookmarks will go into production.  

Project Member

Comment 4 by sheriffbot@chromium.org, Jul 9

Cc: jkrcal@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Sync-Triaged
ascheglov@yandex-team.ru@: bookmarks USS should be mature enough now for you to verify behavior. USS doesn't send populated entity specifics for deletions, so you should expect the same for bookmarks.

I'm wondering why you don't run into the same issue for other USS types.
Status: Assigned (was: Unconfirmed)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.

Sign in to add a comment