New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860286 link

Starred by 3 users
Status: Assigned
Owner:
einbinder@chromium.org
Cc:
█ krajshree@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Devtools contrast ratio widget (within color picker) not available when color is CSS variable

Reported by mike.her...@lullabot.com, Jul 4 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

Steps to reproduce the problem:
1. Create text using CSS Variable
2. Inspect the text. Click the color block to open up the color picker
3. Note that the Contrast Ratio widget is not present.
4. If you set the text color using a normal hex value, the contrast ratio does exist.

Note that I checked both stable and canary releases.

What is the expected behavior?

What went wrong?
I expected the contrast ratio widget to be there

Did this work before? N/A 

Chrome version: 67.0.3396.99  Channel: canary
OS Version: OS X 10.11.6
Flash Version:
color-contrast-ratio-devtools.jpg
123 KB View Download

Comment 1 by krajshree@chromium.org, Jul 5

Labels: Needs-Triage-M67

Comment 2 by krajshree@chromium.org, Jul 6

Cc: krajshree@chromium.org
Labels: Triaged-ET Needs-Feedback
reporter@ - Thanks for filing the issue...!!

Could you please provide a sample test file/url to test the issue from TE-end. This will help us in triaging the issue further.

Thanks...!!

Comment 3 by mike.her...@lullabot.com, Jul 6 

Here you go. Thanks :) 

https://codepen.io/mherchel/pen/wXLEmO
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 6

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by paulir...@chromium.org, Jul 9

Components: -Platform>DevTools Platform>DevTools>Authoring
Owner: einbinder@chromium.org
Status: Assigned (was: Unconfirmed)
Good bug. thanks
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/548c459fb7741b83bd517b12882f533b04a5513e

commit 548c459fb7741b83bd517b12882f533b04a5513e
Author: Joel Einbinder <einbinder@chromium.org>
Date: Fri Oct 12 22:17:09 2018

[DevTools] fix(styles): color contrast info for css variables

Bug: 860286
Change-Id: Iec7cf205d6b240cb54b113690e61414e12685df9
Reviewed-on: https://chromium-review.googlesource.com/c/1278160
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599378}
[modify] https://crrev.com/548c459fb7741b83bd517b12882f533b04a5513e/third_party/blink/renderer/devtools/front_end/elements/StylePropertyTreeElement.js
►

Sign in to add a comment