New issue
Advanced search Search tips

Issue 860281 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 5
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in content::RendererBlinkPlatformImpl::SandboxSupport::GetWebFontRenderStyleForStri

Project Member Reported by ClusterFuzz, Jul 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4596668268544000

Fuzzer: miaubiz_css_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  content::RendererBlinkPlatformImpl::SandboxSupport::GetWebFontRenderStyleForStri
  blink::FontPlatformData::QuerySystemRenderStyle
  blink::FontPlatformData::FontPlatformData
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=572539:572540

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4596668268544000

Additional requirements: Requires Gestures

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 4

Components: Platform
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 4

Labels: Test-Predator-Auto-Owner
Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/b993e42cacf1ed4454b4df62dfacf8eee2bec869 (Move Blink Sandbox IPC to Mojo Calls).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by ClusterFuzz, Jul 5

ClusterFuzz has detected this issue as fixed in range 572707:572709.

Detailed report: https://clusterfuzz.com/testcase?key=4596668268544000

Fuzzer: miaubiz_css_fuzzer
Job Type: linux_ubsan_vptr_chrome
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000000
Crash State:
  content::RendererBlinkPlatformImpl::SandboxSupport::GetWebFontRenderStyleForStri
  blink::FontPlatformData::QuerySystemRenderStyle
  blink::FontPlatformData::FontPlatformData
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=572539:572540
Fixed: https://clusterfuzz.com/revisions?job=linux_ubsan_vptr_chrome&range=572707:572709

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4596668268544000

Additional requirements: Requires Gestures

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 4 by ClusterFuzz, Jul 5

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4596668268544000 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/793a52467d72ef505d22295363fc80369c620898

commit 793a52467d72ef505d22295363fc80369c620898
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Jul 06 11:22:39 2018

Do not access results of RenderStyleForStrike if none was found

Equivalent to what we do when we do not find a fallback font. Fixes the
fact that the return value of the FontRenderStyleForStrike function was
disregarded.

Bug:  860281 
Change-Id: Ib70e7ec819c132590416e9831635a19ae7ff17e5
Reviewed-on: https://chromium-review.googlesource.com/1127622
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572939}
[modify] https://crrev.com/793a52467d72ef505d22295363fc80369c620898/content/child/child_process_sandbox_support_impl_linux.cc

Sign in to add a comment