New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860248 link

Starred by 1 user
Status: Assigned
Owner:
jdoerrie@chromium.org
Cc:
█ markusheintz@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Link to p.g.c. is displayed for all users

Project Member Reported by nepper@chromium.org, Jul 4 
Chrome Version: 67.0.3396.99 (Official Build) (64-bit)
OS: Mac OS X

What steps will reproduce the problem?
(1) Visit chrome://settings/passwords

What is the expected result?
- If I am not signed in to Chrome, I should not see a link to p.g.c.

What happens instead?
- "Access your passwords from any device at p.g.c." is displayed


This should be a regression. I am pretty sure this was implemented correctly when it was launched. We should fix this and create a test to prevent future regressions.

Once fixed, we should merge the fix back to M67/M68 if low risk.

Comment 1 by jdoerrie@chromium.org, Jul 4 

Do we know how far back this possibly could go? I just observed the same behavior in Chrome Version 66.0.3359.139 (Official Build) (64-bit) on macOS 10.13.4.

Comment 2 by jdoerrie@chromium.org, Jul 4 

I'm starting to doubt that this is a regression. I tracked down the initial commit that added the string: https://crrev.com/1834033002 

There has been no initial logic that hides the string when the user is not signed in, and I fail to see any later commits that introduced such behavior.

Comment 3 by nepper@chromium.org, Jul 5

Cc: markusheintz@chromium.org
If I understand the CR correctly, this just changed the layout (see  Issue 595574 ). Maybe Markus has some historic background here?

Comment 4 by markusheintz@google.com, Jul 5 

Sorry I have no memories any more about this. :-(
►

Sign in to add a comment