New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860239 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 851596



Sign in to add a comment

code search fails with cipd packages with variables

Project Member Reported by mar...@chromium.org, Jul 4

Issue description

From https://chromium-review.googlesource.com/1125000 :

"""
Looks like this broke the Codesearch submodule builder: https://ci.chromium.org/buildbot/chromium.infra.codesearch/codesearch-submodules-chromium/43535

It seems to be trying to run a git command on the string "https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}", implying ${platform} hasn't been substituted correctly. Edward, any thoughts? (I don't know anything about the DEPS format).
"""
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f3f4779bbe0debc13f892264cd780bdb74b6871

commit 5f3f4779bbe0debc13f892264cd780bdb74b6871
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Wed Jul 04 12:54:35 2018

Revert "Reland "Add luci-go tool to be fetched via CIPD""

This reverts commit 4e4521b85960399cd22afe33dddaa4516c53f271.

Reason for revert: This broke the code search builder.

Reverting since everyone in the US is OOO, so this wouldn't be fixed for at least two days.

Bug:  860239 

Original change's description:
> Reland "Add luci-go tool to be fetched via CIPD"
> 
> This is a reland of 3bcc71d83f6d9af93a7408fbea34f6d5f0185c03
> 
> Original change's description:
> > Add luci-go tool to be fetched via CIPD
> > 
> > Do not remove the adhoc mechanism on GCS that predates CIPD yet, as the recipes
> > need to be updated.
> > 
> > Change analyze to not ignore changes to isolate.
> > 
> > R=tandrii@chromium.org
> > 
> > Bug: 851596
> > Change-Id: Ic068db83dea4c3a0f17b55181de523b16c9838a5
> > Reviewed-on: https://chromium-review.googlesource.com/1097623
> > Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#569688}
> 
> Bug: 851596
> Change-Id: I27382d97370376dcca8110c9225c16dada182256
> Reviewed-on: https://chromium-review.googlesource.com/1125000
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#572435}

TBR=maruel@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org,jbudorick@chromium.org

Change-Id: Ia95f851c24fab175827fc2a7d5d1472713b909af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851596
Reviewed-on: https://chromium-review.googlesource.com/1125900
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572546}
[modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/DEPS
[modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/testing/buildbot/trybot_analyze_config.json
[modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/.gitignore
[modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/OWNERS
[modify] https://crrev.com/5f3f4779bbe0debc13f892264cd780bdb74b6871/tools/luci-go/README.md

Owner: j...@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/2f10d8cf92319a891be478fb8fc45135461d023c

commit 2f10d8cf92319a891be478fb8fc45135461d023c
Author: Joey Scarr <jsca@google.com>
Date: Thu Jul 05 05:11:52 2018

Skip CIPD URLs in deps2submodules.

This should hopefully solve some issues we've been seeing with the CS
submodule builders where they've been trying to check out things from
CIPD as if they were git repos.

TBR=agable@chromium.org

Bug:  860397 , 860239 
Change-Id: I3040f78c3cfd8d0a8eeeeb3a5a7175b65b044cb4
Reviewed-on: https://chromium-review.googlesource.com/1126693
Reviewed-by: Joey Scarr <jsca@chromium.org>
Commit-Queue: Joey Scarr <jsca@chromium.org>

[modify] https://crrev.com/2f10d8cf92319a891be478fb8fc45135461d023c/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py

Status: Fixed (was: Started)
I think this should be fixed now, let me know if you have any more issues.

Sign in to add a comment