code search fails with cipd packages with variables |
|||
Issue descriptionFrom https://chromium-review.googlesource.com/1125000 : """ Looks like this broke the Codesearch submodule builder: https://ci.chromium.org/buildbot/chromium.infra.codesearch/codesearch-submodules-chromium/43535 It seems to be trying to run a git command on the string "https://chrome-infra-packages.appspot.com/infra/tools/luci/isolate/${platform}", implying ${platform} hasn't been substituted correctly. Edward, any thoughts? (I don't know anything about the DEPS format). """
,
Jul 5
,
Jul 5
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2f10d8cf92319a891be478fb8fc45135461d023c commit 2f10d8cf92319a891be478fb8fc45135461d023c Author: Joey Scarr <jsca@google.com> Date: Thu Jul 05 05:11:52 2018 Skip CIPD URLs in deps2submodules. This should hopefully solve some issues we've been seeing with the CS submodule builders where they've been trying to check out things from CIPD as if they were git repos. TBR=agable@chromium.org Bug: 860397 , 860239 Change-Id: I3040f78c3cfd8d0a8eeeeb3a5a7175b65b044cb4 Reviewed-on: https://chromium-review.googlesource.com/1126693 Reviewed-by: Joey Scarr <jsca@chromium.org> Commit-Queue: Joey Scarr <jsca@chromium.org> [modify] https://crrev.com/2f10d8cf92319a891be478fb8fc45135461d023c/recipes/recipe_modules/sync_submodules/resources/deps2submodules.py
,
Jul 5
I think this should be fixed now, let me know if you have any more issues. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jul 4