New issue
Advanced search Search tips

Issue 860232 link

Starred by 3 users
Status: Assigned
Owner:
tommycli@chromium.org
Cc:
jdonnelly@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Search Google' chip disappears on clicking anywhere on NTP

Reported by khushal....@etouch.net, Jul 4 
Chrome Version : 69.0.3481.0 (Official Build) Revision 1256f448450290ca3d700e80543015dc6f028656-refs/branch-heads/3481@{#1} (32/64-bit)
OS: Windows (7, 8, 8.1, 10), Mac (10.12.6, 10.13.1, 10.13.6, 10.14) & Linux (14.04 LTS)

Steps to reproduce:
(1) Launch chrome, open NTP and press "Ctrl+E" for Search chip to appear along with omnibox suggestion list.
(2) Now click anywhere on NTP outside suggestion list and Observe.

Actual Result: 'Search Google' chip disappears on clicking anywhere on NTP.
Expected Result: 'Search Google' chip should not disappear on clicking anywhere on NTP.

This is a Regression issue broken in 'M-67' and providing the narrow bisect info below:
Good Build: 67.0.3388.0 (Revision: 547924)
Bad Build:  67.0.3389.0 (Revision: 548273)

Narrow bisect URL:

https://chromium.googlesource.com/chromium/src/+log/887d9ca979613fd2b7ee7d5387ff52764480d7cf..dd5a64226c950e9b5ae8a7fbd906e4549401b346

Suspect: r547970 ?

@tommycli: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE:
1. Issue on Mac OS is seen only after enabling flag "Use Views browser windows instead of Cocoa." from chrome://flags.
2. Issue is also seen on M-67 Stable (build #67.0.3396.99), M-68 Beta (build #68.0.3440.42) & M-69 Dev (build #69.0.3472.3).

Kindly refer attached screen cast.

Thank You..!!
Actual Video.mp4
913 KB View Download
Expected Video.mp4
809 KB View Download

Comment 1 by tommycli@chromium.org, Jul 20

Cc: pkasting@chromium.org jdonnelly@chromium.org
pkasting / jdonnelly: Need some feedback below...

Hmm actually I'm not sure what the desired behavior is.

As for tip of tree, if the user enters keyword search mode, but then doesn't type anything, and then unfocuses the Omnibox, we exit keyword search mode. That seems defensible.

The previous behavior was to stay in keyword search mode even if the user didn't enter any search terms. That seems like it could confuse users who blur the Omnibox to try to exit keyword search mode.
►

Sign in to add a comment