New issue
Advanced search Search tips

Issue 860222 link

Starred by 3 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Aug 17
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Regression : Unnecessary tab focus is seen on Date at Uber Tray in Sign out screen

Project Member Reported by mmanchala@chromium.org, Jul 4 
Chrome Version:  69.0.3480.0/10844.0.0 dev channel  Reks,Spring & Paine
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> now at Uber Tray select 'Sign out' option 
(2)In Sign out screen -> At Uber Tray try to click on  date and Observe for 'Check your system time' overlay but on tabbing focus is seen on Date
(Please refer Video)

Expected: 'Check your system time' overlay should be seen on clicking Date at Uber Tray
Actual: Instead  'Check your system time' overlay is seen missing

This is Regression Issue as same is working fine in M-68
Actual_TabFocusOnDate.mp4
8.9 MB View Download
Expected_Overlay.mp4
16.1 MB Download

Comment 1 by tetsui@chromium.org, Jul 5

Cc: -ajha@chromium.org -tetsui@chromium.org
Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)

Comment 2 by tetsui@chromium.org, Jul 5

Status: WontFix (was: Assigned)
This is WAI because we should not show the dialog when a user is not allowed to change the time. Probably the past behavior was wrong.

Comment 3 by mmanchala@chromium.org, Jul 5

Status: Assigned (was: WontFix)
C#2>

If it is intended change then unnecessary tab focus is seen on Date which is (as nothing happens on clicking 'Enter' from keyboard). Attaching screenshot for reference
Reopening issue for confirmation

Thanks..!!
Actual_UnnecessaryTabFocusOnDate.jpg
528 KB View Download

Comment 4 by mmanchala@chromium.org, Jul 5

Summary: Regression : Unnecessary tab focus is seen on Date at Uber Tray in Sign out screen (was: Regression : 'Check your system time' overlay is seen missing on clicking Date at Uber Tray in Sign out screen)

Comment 5 by tetsui@chromium.org, Jul 5

Labels: -Pri-1 -Type-Bug-Regression -M-69 Pri-3 Type-Bug

Comment 6 by tetsui@chromium.org, Aug 16

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/422cb0365fd17eba93ea7310fac9cf0545b50210

commit 422cb0365fd17eba93ea7310fac9cf0545b50210
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Aug 17 08:45:38 2018

Unified: disable date button when unavailable.

This CL disables date time settings button when WebUI settings and
date time dialog are unavailable. For example, it will not be included
in focus traversal on lock screen.

TEST=manual
BUG= 860222 

Change-Id: I54e4f1188596413fdfe0a4d826fbcec8cae85b6a
Reviewed-on: https://chromium-review.googlesource.com/1177463
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583993}
[modify] https://crrev.com/422cb0365fd17eba93ea7310fac9cf0545b50210/ash/system/model/clock_model.cc
[modify] https://crrev.com/422cb0365fd17eba93ea7310fac9cf0545b50210/ash/system/model/clock_model.h
[modify] https://crrev.com/422cb0365fd17eba93ea7310fac9cf0545b50210/ash/system/unified/unified_system_info_view.cc

Comment 8 by tetsui@chromium.org, Aug 17

Status: Fixed (was: Started)
►

Sign in to add a comment