New issue
Advanced search Search tips

Issue 860215 link

Starred by 1 user
Status: Fixed
Owner:
carlosil@chromium.org
Closed: Jul 10
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary horizontal scroll bar appears on chrome://flags page.

Reported by dchau...@etouch.net, Jul 4 
Chrome Version: 69.0.3481.0 (Official Build) Revision	1256f448450290ca3d700e80543015dc6f028656-refs/branch-heads/3481@{#1} 32/64-bit.
OS: Win (7,8,8.1,10) and Mac OS X (10.12.6,10.13.1,10.13.6).

What steps will reproduce the problem?
1. Launch Chrome and navigate to chrome://flags page.
2. Now resize the browser towards LHS and observe. (Refer attached 'Actual behavior' video)

Actual: Unnecessary horizontal scroll bar appears.
Expected: Horizontal scroll bar should not appear.

This is a regression issue, broken in M-66 series, below is manual regression range.

Good build: 66.0.3349.0 (Revision: 537111)
Bad build: 66.0.3350.0 (Revision: 537342)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 537118 (known good), but no later than 537119 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/cc070fe8533e02cb6c0a02d11678b797a27de671..766fbc88bed0c117536f00aab036aef7851a3c03

Suspecting: https://chromium.googlesource.com/chromium/src/+/766fbc88bed0c117536f00aab036aef7851a3c03

@carlosil: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: 
1. This issue is also reproducible on Stable #67.0.3396.99 and Beta #68.0.3440.42
2. This issue is not reproducible on Linux (14.04 LTS) OS.

Kindly review the attached screen-cast for reference.

Thank you.
Actual behavior.mp4
2.0 MB View Download
Expected behavior.mp4
1.7 MB View Download

Comment 1 by carlosil@chromium.org, Jul 10

Status: Started (was: Assigned)

Comment 2 by carlosil@chromium.org, Jul 10

Labels: OS-Linux
Thanks for reporting! I was able to reproduce in Linux too, fix is on the way in crrev.com/c/1132083, looks like this was related to the URL in the description not wrapping.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aafcd73a2fb827cce14e3f9028ac12e844d68469

commit aafcd73a2fb827cce14e3f9028ac12e844d68469
Author: Carlos IL <carlosil@chromium.org>
Date: Tue Jul 10 20:08:37 2018

Changed chrome://flags description for BundledConnectionHelp

The previous description contained a long URL that was not wrapping,
causing a scrollbar to show up in chrome://flags when the window for
some window sized. The description was reworded to remove the URL.

Bug:  860215 
Change-Id: I687997b9eae09eb827a5483cf67ce9e0960a67b6
Reviewed-on: https://chromium-review.googlesource.com/1132083
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Commit-Queue: Carlos IL <carlosil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573875}
[modify] https://crrev.com/aafcd73a2fb827cce14e3f9028ac12e844d68469/chrome/browser/flag_descriptions.cc

Comment 4 by carlosil@chromium.org, Jul 10

Status: Fixed (was: Started)

Comment 5 by dchau...@etouch.net, Jul 11

Labels: TE-Verified-M69 TE-Verified-69.0.3488.0
Update:

Rechecked the above issue on Win (7,8,8.1,10), Mac OS X (10.12.6,10.13.1,10.13.6) & Linux (14.04 LTS) machines using latest canary #69.0.3488.0 and issue is fixed. Hence adding TE-Verified labels.

please refer below attached screen-cast for reference.

Thank You.
Latest Canary behavior.mp4
2.9 MB View Download
►

Sign in to add a comment