New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860206 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug

Blocked on:
issue 860148



Sign in to add a comment

CHECK failure: GLSupportsFormat(resource_format) in raster_decoder.cc

Project Member Reported by ClusterFuzz, Jul 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5674921083273216

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  GLSupportsFormat(resource_format) in raster_decoder.cc
  gpu::raster::RasterDecoderImpl::CreateTexture
  gpu::raster::RasterDecoderImpl::HandleCreateTexture
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572025:572026

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5674921083273216

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 4

Components: Internals>GPU>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 4

Cc: piman@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jul 4

Labels: Test-Predator-Auto-Owner
Owner: sohan.jy...@huawei.com
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/fc3065ef8b01b61681ce95b1bab768869672d29a (viz: Add external GMB formats to ResourceFormat.).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: danakj@chromium.org enne@chromium.org sohanjg@chromium.org
The dcheck was indeed introduced by the mentioned code change.

Couldnt check the cluster fuzz test case (https://clusterfuzz.com/download?testcase_id=5674921083273216, not sure how to open the downloaded file :/)

But, most probably  crbug.com/860148  should handle it. There is indeed a mismatch between the resource formats and the dcheck.
There's a reproduce tool here FWIW: https://github.com/google/clusterfuzz-tools
Thanks for the link, looks like it still needs goma installed to run :/

Put up a speculative fix at https://chromium-review.googlesource.com/c/chromium/src/+/1126393/

Do we have any bots for running the fuzzer, to check with the patch ?
Blockedon: 860148
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a23aad411e02432e2e915e2b05a672c042cb357

commit 5a23aad411e02432e2e915e2b05a672c042cb357
Author: sohan <sohan.jyoti@huawei.com>
Date: Wed Jul 11 18:39:20 2018

viz: Add resource formats to raster cmd buffer.

Use right technique to add new formats instead of hard-coding autogen
files. Also ensure texture creation and GMB import via RasterDecoder
allows all ResourceFormats, but fail in TexStorage2D.

BUG= 860206 , 860148 , 860505 

Change-Id: I54a16a94f9fa0d05dede1d40dbf9095b3d90fce8
Reviewed-on: https://chromium-review.googlesource.com/1126393
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Cr-Commit-Position: refs/heads/master@{#574258}
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/build_raster_cmd_buffer.py
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_decoder_unittest_0_autogen.h

Project Member

Comment 9 by ClusterFuzz, Jul 12

ClusterFuzz has detected this issue as fixed in range 574254:574269.

Detailed report: https://clusterfuzz.com/testcase?key=5674921083273216

Fuzzer: libFuzzer_gpu_raster_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  GLSupportsFormat(resource_format) in raster_decoder.cc
  gpu::raster::RasterDecoderImpl::CreateTexture
  gpu::raster::RasterDecoderImpl::HandleCreateTexture
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572025:572026
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=574254:574269

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5674921083273216

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jul 12

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5674921083273216 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment