New issue
Advanced search Search tips

Issue 860198 link

Starred by 1 user

Issue metadata

Status: Started
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: 2019-07-01
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Task



Sign in to add a comment

Extensions: Get rid of disable_reason::DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC

Project Member Reported by treib@chromium.org, Jul 4

Issue description

This disable reason has supposedly not been used since M48, and we have had cleanup code to remove/replace it since then. However, it turns out that the cleanup code didn't always trigger, so there's a non-trivial number of users left with this reason.

So, tasks:
1) Add proper cleanup code.
2) A while later (say a year), verify that the reason is now gone.
3) Remove the cleanup code.
 
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bdb790baa1c712e88c7a9c134ff1850056e5f7b

commit 4bdb790baa1c712e88c7a9c134ff1850056e5f7b
Author: Marc Treib <treib@chromium.org>
Date: Sat Jul 07 15:02:48 2018

Extensions: Migrate off DEPRECATED_DISABLE_UNKNOWN_FROM_SYNC

This disable reason hasn't been in active use since M48, but it
turns out our previous migration code didn't catch all cases.
This CL adds (hopefully) more robust migration code.

Bug: 860198
Change-Id: I3b81a8cc3941459d501cc3b4d8381250b374f0ab
Reviewed-on: https://chromium-review.googlesource.com/1124686
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573164}
[modify] https://crrev.com/4bdb790baa1c712e88c7a9c134ff1850056e5f7b/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/4bdb790baa1c712e88c7a9c134ff1850056e5f7b/extensions/browser/extension_prefs.cc

NextAction: 2019-07-01

Sign in to add a comment