Add metrics for current fix for autofilling prefilled usernames known as placeholders |
|||||||
Issue descriptionThere are websites that prefill the value of <input> fields with placeholder text, instead of using the placeholder attribute. crrev.com/c/1007723 introduced a fix to allow the password manager to recognize some of these situations and autofill credentials for those cases. Add metrics to help assess the improvement brought by this fix.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c commit 609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c Author: Ioana Pandele <ioanap@chromium.org> Date: Tue Jul 10 09:49:57 2018 Add metrics for the current prefilled usernames fix crrev.com/c/1007723 introduced a fix to allow the password manager to recognize some cases when username fields are prefilled with values that are meant as placeholders and autofill credentials for those cases. This CL adds metrics to help assess the effect of that fix. Bug: 860161 Change-Id: I4475ed757fc41b4e162b00a7e3b6ab830c496932 Reviewed-on: https://chromium-review.googlesource.com/1122977 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#573667} [modify] https://crrev.com/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c/tools/metrics/histograms/enums.xml [modify] https://crrev.com/609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c/tools/metrics/histograms/histograms.xml
,
Jul 10
,
Jul 10
,
Jul 12
This change only adds metrics.
,
Jul 12
This bug requires manual review: Less than 8 days to go before AppStore submit on M68 Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 12
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4722d4576f863f8474099dad7b54dbc3b4900eb2 commit 4722d4576f863f8474099dad7b54dbc3b4900eb2 Author: Dominic Battre <battre@chromium.org> Date: Fri Jul 13 08:02:37 2018 Add metrics for the current prefilled usernames fix crrev.com/c/1007723 introduced a fix to allow the password manager to recognize some cases when username fields are prefilled with values that are meant as placeholders and autofill credentials for those cases. This CL adds metrics to help assess the effect of that fix. TBR=ioanap@chromium.org (cherry picked from commit 609f5d70e6ecb3df0c935cbc3e9ecd2e9519d71c) Bug: 860161 Change-Id: I4475ed757fc41b4e162b00a7e3b6ab830c496932 Reviewed-on: https://chromium-review.googlesource.com/1122977 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#573667} Reviewed-on: https://chromium-review.googlesource.com/1136043 Cr-Commit-Position: refs/branch-heads/3440@{#662} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/4722d4576f863f8474099dad7b54dbc3b4900eb2/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/4722d4576f863f8474099dad7b54dbc3b4900eb2/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/4722d4576f863f8474099dad7b54dbc3b4900eb2/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/4722d4576f863f8474099dad7b54dbc3b4900eb2/tools/metrics/histograms/enums.xml [modify] https://crrev.com/4722d4576f863f8474099dad7b54dbc3b4900eb2/tools/metrics/histograms/histograms.xml |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by ioanap@chromium.org
, Jul 4