New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 860206
issue 860505



Sign in to add a comment

Add new resource formats to oop-raster with tool chain code.

Project Member Reported by sohanjg@chromium.org, Jul 4

Issue description

Recent code changes to add new resource formats https://chromium-review.googlesource.com/c/chromium/src/+/1101678 added formats manually for raster cmd buffer.
Add it via build_raster_cmd_buffer.py and modify previous dchecks to early outs.
 
Description: Show this description
Blocking: 860206
Blocking: 860505
I'll take this. It's blocking some of the RasterDecoder work that I was doing.
Cc: sohanjg@chromium.org
Owner: backer@chromium.org
Status: Started (was: Untriaged)
Oops! I do have a WIP put up here, https://chromium-review.googlesource.com/c/chromium/src/+/1126393/ we can land this if its urgent.
Cc: -sohanjg@chromium.org backer@chromium.org
Owner: sohanjg@chromium.org
It's not that urgent. I don't think that clusterfuzz uncovered anything exploitable (OOP-R is still off by default). I'm going to be out on vacation soon, I'll just workaround it for now.

As I mentioned on your CL, consider the approach here: https://chromium-review.googlesource.com/c/chromium/src/+/1127154
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a23aad411e02432e2e915e2b05a672c042cb357

commit 5a23aad411e02432e2e915e2b05a672c042cb357
Author: sohan <sohan.jyoti@huawei.com>
Date: Wed Jul 11 18:39:20 2018

viz: Add resource formats to raster cmd buffer.

Use right technique to add new formats instead of hard-coding autogen
files. Also ensure texture creation and GMB import via RasterDecoder
allows all ResourceFormats, but fail in TexStorage2D.

BUG= 860206 , 860148 , 860505 

Change-Id: I54a16a94f9fa0d05dede1d40dbf9095b3d90fce8
Reviewed-on: https://chromium-review.googlesource.com/1126393
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sohan Jyoti Ghosh <sohan.jyoti@huawei.com>
Cr-Commit-Position: refs/heads/master@{#574258}
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/components/viz/common/resources/resource_format_utils.cc
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/build_raster_cmd_buffer.py
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_cmd_validation_implementation_autogen.h
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_decoder.cc
[modify] https://crrev.com/5a23aad411e02432e2e915e2b05a672c042cb357/gpu/command_buffer/service/raster_decoder_unittest_0_autogen.h

Status: Fixed (was: Started)

Sign in to add a comment