New issue
Advanced search Search tips

Issue 860139 link

Starred by 1 user
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jul 14
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Print Preview] Default focus doesn't seen on 'Search destination' text-box on 'Select a destination' overlay.

Reported by dchau...@etouch.net, Jul 4 
Chrome Version: 69.0.3480.0 (Official Build)Revision	3c4342c43a5e8e33042613038d4777cc1c9349af-refs/branch-heads/3480@{#1} 32/64-bit.
OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04).

Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags

What steps will reproduce the problem?
1. Launch Chrome, go to NTP or any webpage and give print command  using "Ctrl/Command + P" key from keyboard.
2. Click on 'Change' button under 'Destination' section to open 'Select a destination' overlay and observe.

Actual: Default focus doesn't seen on 'Search destination' text-box.
Expected: Default focus should seen on 'Search destination' text-box.

This is a non-regression issue, seen from M-66 series as 'Enable new Print Preview UI' flag is introduced from M-66 series.

NOTE: This issue is also reproducible on Stable #67.0.3396.99 and Beta #68.0.3440.42

Kindly review the attached screen-cast for reference.

Thank you.
Print behavior.mp4
1.8 MB View Download

Comment 1 by rbasuvula@chromium.org, Jul 4

Status: Untriaged (was: Unconfirmed)
As this being a Non-Regression issue, changing the status to Untriaged so that the issue would get addressed.

Thank You!

Comment 2 by thestig@chromium.org, Jul 6

Owner: rbpotter@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff940402c857175193f8eb20812ee789bc784268

commit ff940402c857175193f8eb20812ee789bc784268
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 11 04:54:14 2018

Print Preview Componentization: Fix destinations dialog focus

Focus the search box when the dialog is shown. Also add an interactive
UI test to verify the behavior and fix the same issue in the advanced
settings dialog.

Bug:  860139 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I925ba10d10a477dfc526d860d5db108534f4254f
Reviewed-on: https://chromium-review.googlesource.com/1130659
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574079}
[modify] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/browser/resources/print_preview/new/print_preview_search_box.html
[modify] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/browser/resources/print_preview/new/print_preview_search_box.js
[add] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/test/data/webui/print_preview/destination_dialog_interactive_test.js
[modify] https://crrev.com/ff940402c857175193f8eb20812ee789bc784268/chrome/test/data/webui/print_preview/print_preview_interactive_ui_tests.js

Comment 4 by rbpotter@chromium.org, Jul 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment