New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 860128 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Ill in short base::internal::CheckOnFailure::HandleFailure<short>

Project Member Reported by ClusterFuzz, Jul 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5720115304464384

Fuzzer: libFuzzer_zucchini_disassembler_dex_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Ill
Crash Address: 0x0000005421ba
Crash State:
  short base::internal::CheckOnFailure::HandleFailure<short>
  short base::internal::checked_cast<short, base::internal::CheckOnFailure, long>
  zucchini::DisassemblerDex::MakeWriteRelCode16
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572202:572204

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5720115304464384

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 4

Components: Internals>Installer>Diff
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 4

Cc: ckitagawa@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jul 4

Labels: Test-Predator-Auto-Owner
Owner: ckitagawa@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c2a778621cbcd812e2687269ba3f10132a31df12 ([Zucchini] Add dissassembler_dex Fuzzer).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d78c3c15a71b517d3ef226010f1cfc4b13e5ea1

commit 2d78c3c15a71b517d3ef226010f1cfc4b13e5ea1
Author: Calder Kitagawa <ckitagawa@chromium.org>
Date: Wed Jul 04 20:44:27 2018

[Zucchini] Enforce valid casts on Rel codes

The MakeWriteRelCodeXX used base::checked_cast which results in a
crash. To fail gracefully we instead use base::CheckedNumeric.

The appearance of this bug results from the input files being bad
resulting in the output from gen also being bad which then propagates
to the apply step.

Bug:  860128 
Change-Id: I38fc91b0a1495ce0c337d778fb51cfe56537e766
Reviewed-on: https://chromium-review.googlesource.com/1126178
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572648}
[modify] https://crrev.com/2d78c3c15a71b517d3ef226010f1cfc4b13e5ea1/components/zucchini/disassembler_dex.cc

Status: Fixed (was: Assigned)
Project Member

Comment 6 by ClusterFuzz, Jul 7

ClusterFuzz has detected this issue as fixed in range 572608:573021.

Detailed report: https://clusterfuzz.com/testcase?key=5720115304464384

Fuzzer: libFuzzer_zucchini_disassembler_dex_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: Ill
Crash Address: 0x0000005421ba
Crash State:
  short base::internal::CheckOnFailure::HandleFailure<short>
  short base::internal::checked_cast<short, base::internal::CheckOnFailure, long>
  zucchini::DisassemblerDex::MakeWriteRelCode16
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572202:572204
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=572608:573021

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5720115304464384

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5720115304464384 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment