New issue
Advanced search Search tips

Issue 860104 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 25
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocking:
issue 800418



Sign in to add a comment

Clicking on a notification from a TWA crashes Chrome

Project Member Reported by dominickn@chromium.org, Jul 4

Issue description

Version: Canary 69.0.3480.0 on a Pixel running Android 8

1. Install Peter's Test TWA (https://drive.google.com/file/d/1SA1gy9mChdu86zRDg-NYJ9kjXRDmNoml/view?usp=sharing) and open it

2. Send a notification from the site

3. Tap on the notification in the notification shade

4. Canary crashes with the following tombstone:


I    3.454s Main  pid: 32631, tid: 32631, name: m.chrome.canary  >>> com.chrome.canary <<<                                                                                                                                                                          [2292/19166]
I    3.454s Main  signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
I    3.454s Main  [FATAL:jni_android.cc(258)] Please include Java exception stack in crash report
I    3.454s Main      r0 00000000  r1 00007f77  r2 00000006  r3 00000008
I    3.454s Main      r4 00007f77  r5 00007f77  r6 ffebf3c0  r7 0000010c
I    3.454s Main      r8 ffebf3f5  r9 ffebf3f4  sl ffebf850  fp ffebf84c
I    3.454s Main      ip 00000000  sp ffebf3b0  lr eafae537  pc eafdec0c
I    3.454s Main
I    3.454s Main  Stack Trace:
I    3.455s Main    RELADDR   FUNCTION   FILE:LINE
I    3.455s Main    0004ac0c  <UNKNOWN>  /system/lib/libc.so
I    3.455s Main    0001a533  <UNKNOWN>  /system/lib/libc.so
I    3.455s Main    00965471  <UNKNOWN>  /data/app/com.chrome.canary-V5NeeL4G4xmdzTkzIwRX-g==/libchrome.so
I    3.455s Main
I    3.455s Main  Java stderr from crashing pid (may identify underlying Java exception):
I    3.455s Main  android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW flg=0x10080000 pkg=com.chrome.canary (has extras) }
I    3.455s Main    at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1936)
I    3.455s Main    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1615)
I    3.455s Main    at android.app.ContextImpl.startActivity(ContextImpl.java:862)
I    3.455s Main    at android.content.ContextWrapper.startActivity(ContextWrapper.java:388)
I    3.455s Main    at ayg.startActivity(SourceFile:70)
I    3.455s Main    at ayg.startActivity(SourceFile:67)
I    3.455s Main    at azh.c(SourceFile:241)
I    3.455s Main    at azh.f(SourceFile:229)
I    3.456s Main    at org.chromium.chrome.browser.ServiceTabLauncher.a(SourceFile:97)
I    3.456s Main    at org.chromium.chrome.browser.ServiceTabLauncher.launchTab(SourceFile:39)
I    3.456s Main    at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method)
I    3.456s Main    at org.chromium.base.SystemMessageHandler.handleMessage(SourceFile:9)
I    3.456s Main    at android.os.Handler.dispatchMessage(Handler.java:105)
I    3.456s Main    at android.os.Looper.loop(Looper.java:164)
I    3.456s Main    at android.app.ActivityThread.main(ActivityThread.java:6541)
I    3.456s Main    at java.lang.reflect.Method.invoke(Native Method)
I    3.456s Main    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
I    3.456s Main    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)
I    3.456s Main
I    3.456s Main  -----------------------------------------------------
I    3.456s Main
I    3.456s Main
I    3.456s Main  pid: 32631, tid: 393, name: TaskSchedulerFo  >>> com.chrome.canary <<<
I    3.457s Main  signal 5 (SIGTRAP), code -32763 (?), fault addr 0x189
I    3.457s Main      r0 c8f7f874  r1 00000089  r2 00000000  r3 c8f7f81c
I    3.457s Main      r4 00000000  r5 ffffffff  r6 ccb284e0  r7 00000000
I    3.457s Main      r8 c8f7f870  r9 c8f7f9c8  sl 00000000  fp 00000000
I    3.457s Main      ip c8f7f7d8  sp c8f7f7c8  lr eafdb941  pc eafacdac
I    3.457s Main
I    3.457s Main  Stack Trace:
I    3.457s Main    RELADDR   FUNCTION   FILE:LINE
I    3.457s Main    00018dac  <UNKNOWN>  /system/lib/libc.so
I    3.457s Main    0004793d  <UNKNOWN>  /system/lib/libc.so
I    3.457s Main    00e360f7  <UNKNOWN>  /data/app/com.chrome.canary-V5NeeL4G4xmdzTkzIwRX-g==/libchrome.so
 
Blocking: 800418
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/custom-tabs-client/+/81a14bc0885944a65afa81acd00da16cecb74b8b

commit 81a14bc0885944a65afa81acd00da16cecb74b8b
Author: Peter E Conn <peconn@chromium.org>
Date: Mon Jul 09 09:10:43 2018

🤝 Expose getVerifiedPackages.

This will allow users to check whether a given origin has any TWAs
associated with it.

Bug:  860104 
Change-Id: Iacad2bfe769c8ca8708e1c254f9fcce2681be3e1
Reviewed-on: https://chromium-review.googlesource.com/1127674
Reviewed-by: Benoit L <lizeb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>

[modify] https://crrev.com/81a14bc0885944a65afa81acd00da16cecb74b8b/customtabs/src/android/support/customtabs/trusted/TrustedWebActivityServiceConnectionManager.java

Issue 862572 has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b87fb02aeeaaee885361a2bc24d79fa005600691

commit b87fb02aeeaaee885361a2bc24d79fa005600691
Author: Peter E Conn <peconn@chromium.org>
Date: Fri Jul 20 19:04:24 2018

🤝 Launch TWAs from notifications.

Check whether an URL can be handled by a Trusted Web Activity when
launched from background Android Services (such as by notifications).

This change also rolls the custom_tabs_client DEP, this roll includes:
057eae40 TrustedWebActivityService can report notifications enabled.
dde0cb7b Improved error reporting for clients.
e8d760cd Better support for client developers.
81a14bc0 Expose getVerifiedPackages, required by this CL.

Bug:  860104 
Change-Id: Ib901a1d4a569e382b168d2c16ea639584913f890
Reviewed-on: https://chromium-review.googlesource.com/1127177
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576940}
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/DEPS
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuPropertiesDelegate.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/java/src/org/chromium/chrome/browser/browserservices/BrowserServicesMetrics.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/java/src/org/chromium/chrome/browser/browserservices/Origin.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/java/src/org/chromium/chrome/browser/browserservices/TrustedWebActivityClient.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java
[modify] https://crrev.com/b87fb02aeeaaee885361a2bc24d79fa005600691/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Assigned)
Labels: Stability-Crash ReleaseBlock-Stable TWA-te M-69
Status: Assigned (was: Fixed)
Verified fix in 70.0.3501.0.
Can we have the fix merged into M69 branch?
Labels: -ReleaseBlock-Stable
Status: Verified (was: Assigned)
Ignore the request for M69 merge. Read about feature not being targeted for M69.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
Labels: -Merge-TBD
Removed the merge label.

Sign in to add a comment