Issue metadata
Sign in to add a comment
|
Magnifiers shortcuts are unusable to turn on the features in signin screen |
||||||||||||||||||||||
Issue description1- Be at the signin screen. 2- Try to enable the docked magnifier by pressing "Search+Ctrl+D" once ---> Nothing happens. 3- Now enter password and login. 4- Notice that the accelerator confirmation dialog is waiting for you (And that's why it didn't turn on). The dialog isn't shown on the signin screen (because it's hidden behind it). You probably need to make the dialog a child of a container [1] that is higher in the hierarchy than the signin screen container. [1]: https://cs.chromium.org/chromium/src/ash/public/cpp/shell_window_ids.h?type=cs&q=ShellWindowId&g=0&l=17
,
Jul 11
,
Jul 18
,
Jul 18
Sara-san, could you take a look? (Sorry I initially thought it's related to my feature but it seems not.)
,
Jul 19
,
Jul 25
I can reproduce this in 69.0.3494.0 (Official Build) dev (64-bit) on Eve. I can't turn on the keyboard shortcuts on the login screen.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/549c9afb39d321f100c6c563aa5d1003842cbed9 commit 549c9afb39d321f100c6c563aa5d1003842cbed9 Author: Sara Kato <sarakato@chromium.org> Date: Thu Jul 26 01:34:08 2018 Show accelerator confirmation dialog on signin screen Dialog may be activated using ctrl+search+(d or m or h). Previously when using the accelerators on the signin screen, the dialog would be displayed after signing in. Bug: 860093 Test: Manual Change-Id: Idb8031d46951d80cd4f5dbcdb0af283b50bbb62d Reviewed-on: https://chromium-review.googlesource.com/1144581 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#578160} [modify] https://crrev.com/549c9afb39d321f100c6c563aa5d1003842cbed9/ash/accelerators/accelerator_confirmation_dialog.cc
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b438c792b5e6fb9408cce1331912b09242fbd42d commit b438c792b5e6fb9408cce1331912b09242fbd42d Author: Sara Kato <sarakato@chromium.org> Date: Thu Jul 26 04:30:35 2018 Show accelerator confirmation dialog on signin screen, follow up Follow up of https://chromium-review.googlesource.com/c/chromium/src/+/1144581 Bug: 860093 Change-Id: I0b243881c2f2ae49f6c4ab31edeffcaf84bf32a0 Reviewed-on: https://chromium-review.googlesource.com/1150951 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#578198} [modify] https://crrev.com/b438c792b5e6fb9408cce1331912b09242fbd42d/ash/accelerators/accelerator_confirmation_dialog.cc
,
Jul 28
I noticed that this is actually a regression of sorts. Please let me know if I should make this into another bug. In 68.0.3440.76 the keyboard shortcuts do turn on the feature; however, the docked magnifier is unable to access the top of the screen per the attached screenshot. It is manageable while signing in but it prevents the add a user field from working at all. That is, it was enabled but had introduced a bug. Updating to 69, the keyboard shortcuts for magnifier do nothing.
,
Jul 28
,
Jul 30
Hi leberly@ I see what you mean regarding the above. I've tested with 67 and 68, and seems as the docked magnifier is not working on the sign in screen (fullscreen magnifier and high contrast are working on both). Using accessibility menu or shortcut respectively. I think the problem may be that on the sign in screen, the entire window is not getting resized to fit underneath the viewport. Rather, the magnifier viewport is just being placed on top of current screen, which might be the cause of the issue. afakhry@ I've had a look at docked_magnifier_controller, but haven't been able to determine where this (screen gets resized to fit under viewport) is done. Would you be able to point me to the applicable code?
,
Jul 30
This is a known bug already tracked by issue 833348 which +alemate@ should be able to fix.
,
Aug 10
,
Sep 6
,
Sep 6
Google Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Also applies to the OOBE > Select Language screen.
,
Sep 6
Google Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Also applies to the OOBE > Accessibility screen.
,
Sep 6
Google Chrome 70.0.3538.7 (Official Build) dev (64-bit) Firmware Version Google_Caroline.7820.384.0 Also applies to the OOBE > Connect to network screen.
,
Sep 6
Google Chrome 70.0.3532.8 (Official Build) dev (64-bit) Google_Eve.9584.160.0 Also applies to OOBE > Terms of Service Page
,
Sep 6
Google Chrome 70.0.3532.8 (Official Build) dev (64-bit) Google_Eve.9584.160.0 Also applies to OOBE > Checking for updates page
,
Sep 6
Google Chrome 70.0.3532.8 (Official Build) dev (64-bit) Google_Eve.9584.160.0 Also applies to Powerwash dialogs (after restarting before accepting the powerwash)
,
Sep 6
Google Chrome 70.0.3538.7 (Official Build) dev (64-bit) Google_Eve.9584.160.0 Also applies to OOBE > "One last thing" screen
,
Nov 29
,
Dec 1
,
Dec 1
,
Jan 3
Friendly ping -- any further updates here?
,
Jan 3
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Jul 9