Issue metadata
Sign in to add a comment
|
SessionRestoreTest.MemoryPressureLoadsNotAllTabs is Flaky |
||||||||||||||||||||||
Issue descriptionFindit has detected flake occurrences for the test SessionRestoreTest.MemoryPressureLoadsNotAllTabs Culprit (96.0% confidence): https://chromium-review.googlesource.com/q/I9f670ab08587ad4c5f626eb74fe5d7c9db256150 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ6Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNjYzMy9icm93c2VyX3Rlc3RzL1UyVnpjMmx2YmxKbGMzUnZjbVZVWlhOMExrMWxiVzl5ZVZCeVpYTnpkWEpsVEc5aFpITk9iM1JCYkd4VVlXSnoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SessionRestoreTest.MemoryPressureLoadsNotAllTabs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ6Y2hyb21pdW0uY2hyb21pdW1vcy9saW51eC1jaHJvbWVvcy1kYmcvNjYzMy9icm93c2VyX3Rlc3RzL1UyVnpjMmx2YmxKbGMzUnZjbVZVWlhOMExrMWxiVzl5ZVZCeVpYTnpkWEpsVEc5aFpITk9iM1JCYkd4VVlXSnoMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
,
Jul 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a49d91b6992b8d3357efeb32a2005d5b11ada26a commit a49d91b6992b8d3357efeb32a2005d5b11ada26a Author: Takuto Ikuta <tikuta@chromium.org> Date: Wed Jul 04 00:30:07 2018 Revert "CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well" This reverts commit 18ba607af1f7ed07275e15824b430ae10976a9b8. Reason for revert: Speculative revert for consistent failure on linux-chromeos-rel CQ builder. Original change's description: > CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well > > LayerTreeHostImpl::OnMemoryPressure has only worked for low-end devices. > But it would be good if it works for all devices. > > Bug: 839687 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I9f670ab08587ad4c5f626eb74fe5d7c9db256150 > Reviewed-on: https://chromium-review.googlesource.com/1107025 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572216} TBR=ericrk@chromium.org,gyuyoung.kim@lge.com Change-Id: I5e8d81f540311373a3d79854310ec59896494cae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 839687, 860090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1125459 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#572405} [modify] https://crrev.com/a49d91b6992b8d3357efeb32a2005d5b11ada26a/cc/trees/layer_tree_host_impl.cc
,
Jul 4
,
Jul 4
Let me remove Sheriff-Chromium label since the suspicious CL has been reverted.
,
Jul 4
Thank you for reverting it. I'm taking a look the CL again.
,
Jul 4
Findit identified the culprit r572216 with confidence 85.6% in the config "chromium.memory / Linux Chromium OS ASan LSan Tests (1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKKAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI4MTM1L2Jyb3dzZXJfdGVzdHMvVTJWemMybHZibEpsYzNSdmNtVlVaWE4wTGsxbGJXOXllVkJ5WlhOemRYSmxURzloWkhOT2IzUkJiR3hVWVdKegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20SessionRestoreTest.MemoryPressureLoadsNotAllTabs&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVywQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKKAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI4MTM1L2Jyb3dzZXJfdGVzdHMvVTJWemMybHZibEpsYzNSdmNtVlVaWE4wTGsxbGJXOXllVkJ5WlhOemRYSmxURzloWkhOT2IzUkJiR3hVWVdKegwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jul 10
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/069adb163044004e3f0676d97baac83a2867050c commit 069adb163044004e3f0676d97baac83a2867050c Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Thu Jul 26 04:09:58 2018 Re-land "CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well" This reverts commit a49d91b6992b8d3357efeb32a2005d5b11ada26a. The original commit made SessionRestoreTest.MemoryPressureLoadsNotAllTabs crash. According to my investigation, it was caused by calling SingleThreadProxy::OnCanDrawStateChanged on the main thread. To avoid it, this CL makes LayerTreeHostImpl::OnMemoryPressure call OnPurgeMemory on the impl thread through the Proxy. Bug: 839687, 860090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifaef5bcb4029da8645f393d85313be4637aea994 Reviewed-on: https://chromium-review.googlesource.com/1130567 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#578192} [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/test/fake_layer_tree_host_impl_client.h [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/proxy_impl.cc [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/proxy_impl.h [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/single_thread_proxy.cc [modify] https://crrev.com/069adb163044004e3f0676d97baac83a2867050c/cc/trees/single_thread_proxy.h
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b555ecd8a69a1cbd27c8a604a7a520d40970480b commit b555ecd8a69a1cbd27c8a604a7a520d40970480b Author: Ned Nguyen <nednguyen@google.com> Date: Tue Jul 31 14:02:50 2018 Revert "Re-land "CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well"" This reverts commit 069adb163044004e3f0676d97baac83a2867050c. Reason for revert: crash rendering.mobile/microsoft_fireflies benchmark test on chromium.perf/android-nexus5x-perf BUG:869188 Original change's description: > Re-land "CC: Make LayerTreeHostImpl::OnMemoryPressure work for the desktop as well" > > This reverts commit a49d91b6992b8d3357efeb32a2005d5b11ada26a. > > The original commit made SessionRestoreTest.MemoryPressureLoadsNotAllTabs crash. > According to my investigation, it was caused by calling SingleThreadProxy::OnCanDrawStateChanged > on the main thread. To avoid it, this CL makes LayerTreeHostImpl::OnMemoryPressure call > OnPurgeMemory on the impl thread through the Proxy. > > Bug: 839687, 860090 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ifaef5bcb4029da8645f393d85313be4637aea994 > Reviewed-on: https://chromium-review.googlesource.com/1130567 > Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> > Reviewed-by: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578192} TBR=enne@chromium.org,ericrk@chromium.org,gyuyoung.kim@lge.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 839687, 860090 Change-Id: I0468da7dd808d545b4a6fe9d59f94d5427e40228 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1156564 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#579392} [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/test/fake_layer_tree_host_impl_client.h [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/layer_tree_host_impl.h [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/layer_tree_host_impl_unittest.cc [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/proxy_impl.cc [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/proxy_impl.h [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/single_thread_proxy.cc [modify] https://crrev.com/b555ecd8a69a1cbd27c8a604a7a520d40970480b/cc/trees/single_thread_proxy.h
,
Aug 2
,
Aug 17
,
Oct 4
Once my commit was reverted to fix this issue. And I had fixed this issue on https://chromium-review.googlesource.com/c/chromium/src/+/1183012. I think this issue should not happen when this CL is landed. But the CL is still ongoing review because of another issue.
,
Jan 14
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by Findit
, Jul 4