New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 860087 link

Starred by 1 user
Status: Fixed
Owner:
shend@chromium.org
Closed: Jul 4
Cc:
omrilio@chromium.org
█ blakeo@chromium.org
yhanada@chromium.org
pcovell@chromium.org
█ dvallet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

App list folder view broken with floating VK

Project Member Reported by shend@chromium.org, Jul 4 
Chrome Version: Canary
OS: ChromeOS Eve

What steps will reproduce the problem?
(1) Open the app launcher in tablet mode
(2) Make a folder with some apps in it
(3) Tap the folder name to change it
(4) Switch to floating mode.

What is the expected result?
The folder view should stay where it is and I'll be able to type a new name.

What happens instead?
The folder view jumps off screen.

See attached video.
applist-floating.webm
3.5 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ef3038de5350cefacba396b74c084f164b5cb90

commit 2ef3038de5350cefacba396b74c084f164b5cb90
Author: Darren Shen <shend@chromium.org>
Date: Wed Jul 04 03:46:10 2018

[VK] Check for empty occluded bounds in AppListFolderView.

In AppListFolderView, we currently use the virtual keyboard occluded
bounds without checking if it's empty first. This means that when we
use the floating keyboard, which has empty occluded bounds,
AppListFolderView thinks that the occluded y position is 0, so it
overscrolls the view off the screen.

We change the code to only overscroll if the occluded bounds are not
empty.

Bug:  860087 
Change-Id: Ibab4170a73932c587bb87ef368a1682885189429
Reviewed-on: https://chromium-review.googlesource.com/1124733
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572465}
[modify] https://crrev.com/2ef3038de5350cefacba396b74c084f164b5cb90/ash/app_list/views/app_list_folder_view.cc
[modify] https://crrev.com/2ef3038de5350cefacba396b74c084f164b5cb90/ash/app_list/views/app_list_view.h

Comment 2 by shend@chromium.org, Jul 4

Components: UI>Shell>Launcher
Status: Fixed (was: Assigned)
►

Sign in to add a comment