New issue
Advanced search Search tips

Issue 860030 link

Starred by 2 users
Status: Fixed
Owner:
dmu...@chromium.org
Closed: Jan 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Session storage should not store data on disk on Android.

Project Member Reported by dmu...@chromium.org, Jul 3 
The new session storage doesn't clean up unused namespaces on startup for android, as the session restore code is never used.

To solve, this, we can either delete the database on startup, or post a after-startup task to do the scavenging.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 12 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860

commit 154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Jul 12 19:18:50 2018

[SessionStorage] Always delete Session Storage database on Android

Android doesn't have session restore code run, and this code is what
cleaned up old session storage namespaces from previous browser runs.

So on Android, the session storage context will delete the database
on startup.

R=mek@chromium.org

Bug:  860030 
Change-Id: Ia7c349811e4970d05a071a0de9ad50117d771855
Reviewed-on: https://chromium-review.googlesource.com/1125260
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574673}
[modify] https://crrev.com/154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860/content/browser/dom_storage/dom_storage_context_wrapper.cc
[modify] https://crrev.com/154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860/content/browser/dom_storage/session_storage_context_mojo.cc
[modify] https://crrev.com/154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860/content/browser/dom_storage/session_storage_context_mojo.h
[modify] https://crrev.com/154ac5551c1e0ff8c877b4cd0e26ad6ea30d4860/content/browser/dom_storage/session_storage_context_mojo_unittest.cc

Comment 2 by dmu...@chromium.org, Jan 3

Status: Fixed (was: Assigned)
The current solution seems good enough.
►

Sign in to add a comment