Fix Desugar issues with multiple android_library layers |
||
Issue description
Android desugaring does not seem to work properly if there are multiple layers of android_library dependencies. Specifically, if we have the following setup:
android_library("lib_a") { ... }
android_library("lib_b") { ... deps = ["lib_a"] ... }
android_library("lib_c") { ... deps = ["lib_b"] ... }
"lib_c" can fail during the desugaring step due to being unable to find files from "lib_a". This can be worked around by manually including "lib_a"'s files in "lib_c".
,
Jul 11
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/480948fd78392694de208a180b236c6d4824bdf6 commit 480948fd78392694de208a180b236c6d4824bdf6 Author: Pavel Shmakov <pshmakov@chromium.org> Date: Mon Sep 24 23:30:52 2018 Work around desugaring issue with tests Use full classpath for desugar as a temporary measure against the desugaring issue in tests. Bug: 860018, 885273 Change-Id: I0d314dceb31c7df2176bfa6fab452afaa541e22c Reviewed-on: https://chromium-review.googlesource.com/1236434 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593742} [modify] https://crrev.com/480948fd78392694de208a180b236c6d4824bdf6/build/config/android/internal_rules.gni [modify] https://crrev.com/480948fd78392694de208a180b236c6d4824bdf6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityIncognitoTest.java [modify] https://crrev.com/480948fd78392694de208a180b236c6d4824bdf6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestRule.java [modify] https://crrev.com/480948fd78392694de208a180b236c6d4824bdf6/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabsTestUtils.java |
||
►
Sign in to add a comment |
||
Comment 1 by agrieve@chromium.org
, Jul 4