New issue
Advanced search Search tips

Issue 860009 link

Starred by 2 users
Status: Fixed
Owner:
bajones@chromium.org
Closed: Jul 8
Cc:
bsheedy@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

VR controller "pops" between positions.

Project Member Reported by bajones@chromium.org, Jul 3 
3DoF VR controllers in VRShell or WebXR snap between positions when moving your head as if it's aligning to a grid. Arm-modeled controller positions should smoothly follow head position.

This appears to be caused by a positional deadzone introduced to prevent noisy controller data from affecting tests.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd44cbad4b543f228aff3233c4e14fa3c3f652ab

commit cd44cbad4b543f228aff3233c4e14fa3c3f652ab
Author: Brandon Jones <bajones@chromium.org>
Date: Sat Jul 07 22:26:48 2018

Fixed 3DoF VR controller snapping between positions

Deadzone introduced to make tests more stable was large enough to cause
noticable visual popping. Corrected by allowing controllers to update
position every frame but not contribute to the scene's "dirty" state.

Bug:  860009 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6e8b5fb4bcf646094dbd529ba3f80da912216aa5
Reviewed-on: https://chromium-review.googlesource.com/1125132
Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573175}
[modify] https://crrev.com/cd44cbad4b543f228aff3233c4e14fa3c3f652ab/chrome/browser/android/vr/vr_controller.cc
[modify] https://crrev.com/cd44cbad4b543f228aff3233c4e14fa3c3f652ab/chrome/browser/vr/elements/controller.h

Comment 2 by bajones@chromium.org, Jul 8

Status: Fixed (was: Started)
►

Sign in to add a comment