New issue
Advanced search Search tips

Issue 860007 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

autotest: shell_wrapper._run_command has potential to deadlock

Project Member Reported by rrangel@chromium.org, Jul 3

Issue description

If _run_command is called with block=True(default) then if the stderr or stdout > then the os buffer a deadlock could occur.

https://chromium.googlesource.com/chromiumos/third_party/autotest/+/master/client/cros/faft/utils/shell_wrapper.py#33

See the warning at https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait

We should be using .communicate()
 
Owner: waihong@chromium.org
Labels: Hotlist-Fixit
Owner: ayatane@chromium.org
Status: Assigned (was: Untriaged)
Owner: ----
Status: Available (was: Assigned)

Sign in to add a comment