New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859999 link

Starred by 2 users
Status: Fixed
Owner:
█ acondor@chromium.org
Last visit > 30 days ago
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Grid is barely visible when dialog is shown in WebVR

Project Member Reported by acondor@chromium.org, Jul 3 
Chrome Version: 68+
OS: Android

What steps will reproduce the problem?
(1) Give chrome permissions to microphone.
(2) Go to https://immersive-web.github.io/webxr-samples/tests/permission-request.html
(3) Enter VR
(4) Click microphone

What is the expected result?
A permission dialog is shown is black environment with a floor grid.

What happens instead?
The grid is barely visible.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c9c6944d48ccde63af68d146dec9cb9542021de

commit 3c9c6944d48ccde63af68d146dec9cb9542021de
Author: Aldo Culquicondor <acondor@chromium.org>
Date: Thu Jul 05 21:42:45 2018

VR: bring back floor gradients

When optimizing the grid gradient in crrev.com/c/1065574, some
background colors where lost. Here we recover them by adding a backing
gradient rect.

BUG= 859999 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I47169c6954bc7662f1ea9a3006f7ae30ebe1ec4e
Reviewed-on: https://chromium-review.googlesource.com/1125094
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572858}
[modify] https://crrev.com/3c9c6944d48ccde63af68d146dec9cb9542021de/chrome/browser/vr/ui_scene_creator.cc

Comment 2 by acondor@chromium.org, Jul 6

Labels: Merge-Request-68
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 6

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cma...@chromium.org, Jul 9 

Please add the rationale why this should be merged into M68.

Comment 5 by acondor@chromium.org, Jul 9

Labels: -Hotlist-Merge-Review -Merge-Review-68
Status: Fixed (was: Started)
This would be great to have, but if it's too late to merge a non-critical issue, that's okay.  Thanks for assessing!

Comment 6 by acondor@chromium.org, Jul 9

Labels: -M-68 M-69
►

Sign in to add a comment