Issue metadata
Sign in to add a comment
|
"virtual/outofblink-cors/http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html" is flaky |
||||||||||||||||||||
Issue description"virtual/outofblink-cors/http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyegsSBUZsYWtlIm92aXJ0dWFsL291dG9mYmxpbmstY29ycy9odHRwL3Rlc3RzL2ZldGNoL3NlcnZpY2V3b3JrZXItcHJveGllZC90aG9yb3VnaC9zY2hlbWUtZGF0YS1iYXNlLWh0dHBzLW90aGVyLWh0dHBzLmh0bWwM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jul 4
,
Jul 4
Sorry, I merged it to this by mistake.
,
Jul 4
Deprioritized this issue since it's under a flag and the test has been disabled.
,
Jul 11
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3 commit 627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3 Author: Yutaka Hirano <yhirano@chromium.org> Date: Fri Jul 20 01:26:52 2018 [OOR-CORS] Reorganize layout test expectations for site-per-process virtual/outofblink-cors and virtual/outofblink-cors-ns should inherit existing test expectations. There is a dedicated bug for virtual/outofblink-cors, https://crbug.com/854630 , but that doesn't make sense as none of them are OOR-CORS specific, so I changed the bug number. TBR=dcheng@chromium.org No-Try: true Bug: 834185 , 854630 , 859988, 862184 Change-Id: I4886c8ed063e95306d79234649dbc54a8bb53100 Reviewed-on: https://chromium-review.googlesource.com/1144582 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#576749} [modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/627748f5bf4ffd7fd4bda776f1c21b8fbe3af4e3/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7663e81247c1494770dd8de1603b648a4aaeeeb commit b7663e81247c1494770dd8de1603b648a4aaeeeb Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Tue Aug 21 18:23:30 2018 |RenderFrameHost*| shouldn't be used as a key by BlinkTestController. Addresses can be reused and therefore pointers shouldn't be used as container keys (unless the code maintaining the container can guarantee that the old entry will be destroyed before the pointer gets freed). In particular, using |RenderFrameHost*| as a key of BlinkTestController's layout_test_control_map_ was incorrect and led to timeouts described in more details in https://crbug.com/834185#c13 - #c14. This CL replaces std::map<RenderFrameHost*, ...> with std::map<std::pair<int, int>, ...> and uses (process id, frame routing id) as a key. After this CL around ~200 flaky timeouts from FlagExpectations/site-per-process seem to avoided. Before this CL, I could reliably repro a timeout in - http/tests/fetch/window/thorough/redirect-nocors-base-https-other-https.html - http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html when running it 20 iterations. After this CL, I cannot repro any timeouts when running all ~200 tests 20 times: $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests \ -t rel --no-retry --additional-driver-flag=--site-per-process \ --iterations=20 \ --exit-after-n-failures=1 --exit-after-n-crashes-or-timeouts=1 \ --additional-driver-flag=--no-sandbox \ --additional-driver-flag=--isolate-origins=http://www.web-platform.test:8001/,http://www1.web-platform.test:8001/,http://www2.web-platform.test:8001/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8001/,http://xn--lve-6lad.web-platform.test:8001/,http://www.web-platform.test:8081/,http://www1.web-platform.test:8081/,http://www2.web-platform.test:8081/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8081/,http://xn--lve-6lad.web-platform.test:8081/,https://www.web-platform.test:8444/,https://www1.web-platform.test:8444/,https://www2.web-platform.test:8444/,https://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8444/,https://xn--lve-6lad.web-platform.test:8444/ \ --test-list=$HOME/scratch/test-list ... Found 206 tests; running 206 (20 times each: --repeat-each=1 --iterations=20), skipping 0. ... All 4120 tests ran as expected. Bug: 801992 , 834185 , 711468 , 859988 Change-Id: I9f2c1abf87027fcb3824c54e597e561ac72babb9 Reviewed-on: https://chromium-review.googlesource.com/1182316 Commit-Queue: Ćukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584841} [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.h [modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Jul 3