New issue
Advanced search Search tips

Issue 859983 link

Starred by 1 user
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jul 7
Cc:
vamshi.kommuri@chromium.org
jdoerrie@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Settings: Focusing cr-link-row on subpage exit not working.

Project Member Reported by dpa...@chromium.org, Jul 3 
When exiting a subpage the icon that triggers the subpage is supposed to automatically be focused. This used to work, but regressed at r544912 (found after bisecting).

Repro steps:
 1) Go to chrome://settings
 2) Click on "Customize fonts" in the appearance section.
 3) Exit the subpage (keyboard or mouse)
 4) Observe focus. (If used keyboard a ripple should be visible, otherwise just hit "Enter" and see if the subpage re-opens).

Expected: Focus should be on the subpage arrow icon.
Actual: Focus is lost.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fe015851ebc02d18736490caf5db3e42f29884e

commit 4fe015851ebc02d18736490caf5db3e42f29884e
Author: dpapad <dpapad@chromium.org>
Date: Fri Jul 06 18:40:27 2018

Settings WebUI: Fix cr-link-row focus() to focus the icon.

This was broken when cr-link-row was converted to a <button> wrapper at r544912.
Also fixing related runtime error thrown by the newly added cr-link-row instances
in people_page.html.

Bug:  859983 , 858880 
Change-Id: I277d02a8a356a36d1ac64e18019f65c3f904c9c3
Reviewed-on: https://chromium-review.googlesource.com/1125089
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573025}
[modify] https://crrev.com/4fe015851ebc02d18736490caf5db3e42f29884e/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/4fe015851ebc02d18736490caf5db3e42f29884e/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js

Comment 2 by dpa...@chromium.org, Jul 7

Owner: dpa...@chromium.org
Status: Fixed (was: Available)

Comment 3 by vamshi.kommuri@chromium.org, Jul 9

Cc: vamshi.kommuri@chromium.org
Labels: TE-Verified-69.0.3486.0 TE-Verified-M69
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #69.0.3486.0 as per the comment #0.
Attaching screen cast for reference.
Observed that the focus stayed on subpage arrow icon.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!
859983 CL Verification.mp4
1.1 MB View Download
►

Sign in to add a comment