New issue
Advanced search Search tips

Issue 859981 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug



Sign in to add a comment

Add red recording dot on the tab that starts desktop capture

Project Member Reported by braveyao@chromium.org, Jul 3

Issue description

Add red recording dot on the tab that starts desktop capture.
As part of the required feature of the new getDisplayMedia API.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477

commit 63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477
Author: braveyao <braveyao@chromium.org>
Date: Tue Jul 10 19:08:53 2018

[desktopCapture] Add red recording dot on the caller tab

This cl is to add a red recording dot indicator for the tab that starts
the desktop capture.
This is part of the required UI change for the new getDisplayMaid API.

Bug:  859981 
Change-Id: I9e36f6a4c61802152936282ba5f3902db1f774cd
Reviewed-on: https://chromium-review.googlesource.com/1125079
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573846}
[modify] https://crrev.com/63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477/chrome/app/generated_resources.grd
[modify] https://crrev.com/63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477/chrome/browser/ui/tabs/tab_utils.cc
[modify] https://crrev.com/63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477/chrome/browser/ui/tabs/tab_utils.h
[modify] https://crrev.com/63ecd6992bb1d9f4ae59df04d0fd346ae6d2c477/chrome/browser/ui/views/tabs/tab.cc

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7816ed92a6ce2b14866e8f9992db46b1d3fc9880

commit 7816ed92a6ce2b14866e8f9992db46b1d3fc9880
Author: Weiyong Yao <braveyao@chromium.org>
Date: Thu Aug 09 22:37:34 2018

Revise tooltip content for screen sharing per suggestion from UX writer.

UX and PM think it's better to say "This tab is sharing your screen.".
Also fixed a typo in desc.

Bug:859981

TBR=rockot@chromium.org

Change-Id: I503ab2ce47190ed1069e99a58eaa01c001558a8e
Reviewed-on: https://chromium-review.googlesource.com/1169540
Reviewed-by: Weiyong Yao <braveyao@chromium.org>
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581934}
[modify] https://crrev.com/7816ed92a6ce2b14866e8f9992db46b1d3fc9880/chrome/app/generated_resources.grd
[add] https://crrev.com/7816ed92a6ce2b14866e8f9992db46b1d3fc9880/chrome/app/generated_resources_grd/IDS_TOOLTIP_TAB_ALERT_STATE_DESKTOP_CAPTURING.png.sha1

Sign in to add a comment