Infra code review request involving "git cl try-results" and "cit logdog query" |
||||
Issue descriptionWe have several hundred accessibility tests that output platform-specific results. Sometimes when refactoring we need to update many tests, this is somewhat similar to how Blink layout tests work. We're using this script to run try jobs and then collect the differences: tools/accessibility/rebase_dump_accessibility_tree_test.py The current iteration of the script uses "git cl try-results" and "cit logdog query", but it's probably still not that robust, it still manually assembles the logdog query. Any ideas on how we could make this more robust, i.e. so that changes to infrastructure are less likely to break it? Are there infra tests? Could we write a test that would fail if somebody tried to make infra changes that would stop this script from working?
,
Jul 26
It's probably better to get the underlying Swarming task result directly. In particular you could look at a task output.json instead of scraping logs, which is bound to be brittle. Taking for example: https://chromium-swarm.appspot.com/tasklist?c=name&c=state&c=created_ts&c=buildername-tag&c=buildnumber-tag&et=1532632740000&f=stepname-tag%3Acontent_browsertests&l=500&n=true&s=created_ts%3Adesc&st=1532546340000 When you take a specific task, example: https://chromium-swarm.appspot.com/task?id=3ef0d6056bc10110 You can browse the isolated outputs, i.e.: https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=394556fc0a32b0b21f49da6612f0badf7a649cda which leads you to the output.json result summary: https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=7cefcc99a9bfdeca4042feb7216ba7a2d070dbb5&as=output.json ... which is better than scraping logs.
,
Oct 18
,
Oct 18
|
||||
►
Sign in to add a comment |
||||
Comment 1 by vadimsh@chromium.org
, Jul 25Components: -Infra Infra>Platform