New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859941 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 860193
Owner:
Closed: Jul 9
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Turn on OOP Raster on android bots regresses memory

Project Member Reported by hjd@google.com, Jul 3

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=859941

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=51fa30b54e8394c67ed12b89ca9c7dd2af909998ba3c03e40bef71fa36e7a11a


Bot(s) for this bug's original alert(s):

health-plan-clankium-low-end-phone
Cc: enne@chromium.org
Owner: enne@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author enne@chromium.org ===

Hi enne@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Adrienne Walker
  Commit : d82c4fabc5cc6cbe6b475186ed9fa0216980e533
  Date   : Fri Jun 29 22:55:43 2018
  Subject: Turn on OOP Raster on android bots

Bisect Details
  Configuration: clankium-low-end-phone-perf-bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:gpu_memory:proportional_resident_size_avg/foreground/http_www_amazon_com_gp_aw_s_k_nexus
  Change       : 21.17% | 9081173.33333 -> 11003562.6667

Revision                                       Result                  N
android-chrome@23ce5c27b6                      9081173 +- 237739       6      good
android-chrome@23ce5c27b6,chromium@571692      9255936 +- 209745       6      good
android-chrome@23ce5c27b6,chromium@571693      9649152 +- 626265       6      good
android-chrome@23ce5c27b6,chromium@571694      10844843 +- 135371      6      bad       <--
android-chrome@23ce5c27b6,chromium@571698      10975915 +- 306458      6      bad
android-chrome@24cae43d5e                      10932224 +- 287164      6      bad
android-chrome@cd28519e8e                      10888533 +- 306458      6      bad
android-chrome@8dba9381aa                      11003563 +- 336153      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chrome --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.www.amazon.com.gp.aw.s.k.nexus memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8942004491093448560


For feedback, file a bug with component Speed>Bisection
Cc: benhenry@chromium.org ushesh@chromium.org
Labels: -Pri-2 ReleaseBlock-Beta Pri-1
This creates a pretty large memory regression in graphics, about 12 MiB in average for top_10_mobile.

Is such a large increase expected? A fix or justification will be needed soon, since this is likely to block the next release.
Cc: perezju@google.com
 Issue 860167  has been merged into this issue.
 Issue 860165  has been merged into this issue.
Summary: Turn on OOP Raster on android bots regresses memory (was: 7.6% regression in memory.top_10_mobile at 1530336528:1530348392)
Cc: primiano@google.com
 Issue 860740  has been merged into this issue.
 Issue 860753  has been merged into this issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jul 9

Cc: perezju@chromium.org
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label.

All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Mergedinto: 860193
Status: Duplicate (was: Assigned)
This is from turning on oop rasterization, which is currently only turned on for bots and hasn't been turned on trunk yet.  We're looking into this.

Sign in to add a comment