New issue
Advanced search Search tips

Issue 859939 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jul 3
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0.3% regression in sizes at 572124:572124

Project Member Reported by hjd@google.com, Jul 3

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=859939

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=08a67e3d7ae323ea52b8350b0c8f71b35458b7e35d5c81de8f5a0ef177f897fe


Bot(s) for this bug's original alert(s):

linux
Owner: g...@chromium.org
Status: Assigned (was: Untriaged)
Assigning to sheriff gbiv@chromium.org because this autoroll is the only CL in range:
Roll AFDO from 69.0.3479.0_rc-r1 to 69.0.3480.0_rc-r1

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context:  https://crbug.com/805539 

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I8dfa0e2421a7c9142bc0a0381be714acfe2faab0
Reviewed-on: https://chromium-review.googlesource.com/1124101
Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#572124}
Status: WontFix (was: Assigned)
Looks like this 447KB regression is on the heels of a 360KB or so improvement granted by AFDO (r571039). These kinds of fluctuations, sadly, happen sometimes. Denoising is being tracked in issue 849881.

For context, AFDO profiles are generated by sampling Chrome's execution and feeding that back into the compiler, so the compiler can better optimize Chrome. This process is inherently noisy, so we'll sometimes see benchmarks that are highly sensitive to certain optimizations being performed (read: many of blink's benchmarks) swing around from time to time, and we’ll sometimes see Chrome vary in size as the inliner/vectorizer/etc. decides to be more/less aggressive.

Sign in to add a comment