New issue
Advanced search Search tips

Issue 859938 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Jul 31
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

MacViews RTL: Focus is weird when dragging tabs

Project Member Reported by lgrey@chromium.org, Jul 3 
Dragging a tab triggers focus changes via TabDragController::SaveFocus (https://cs.chromium.org/chromium/src/chrome/browser/ui/views/tabs/tab_drag_controller.cc?q=TabDragController::SaveFocus&sq=package:chromium&dr=CSs&l=548)

When this is called in RTL, something goes wrong deep in the focus restoration code, and the wrong thing happens:
- If a tab close button is selected, it keeps its focus ring, sometimes drawing on top of the tab being dragged. See attached video
- If the omnibox is selected, the omnibox loses focus, unlike in LTR or RTL on other platforms
restore.mov
115 KB View Download

Comment 1 by meh...@chromium.org, Jul 3 

> If the omnibox is selected, the omnibox loses focus, unlike in LTR or RTL on other platforms

That it is probably  issue 835550 .

Comment 2 by robliao@chromium.org, Jul 12

Labels: Group-Focus_Input_Selection_Activation_KeyState

Comment 3 by a...@chromium.org, Jul 30 

Leonard, can you still repro? I can't at e1a4f4114902.
focus.mov
404 KB View Download

Comment 5 by lgrey@chromium.org, Jul 31 

BTW avi@ you need to either log in and out or launch with "-NSForceRightToLeftWritingDirection YES -AppleTextDirection YES" to fully trigger RTL on the OS side (note location of stoplights)
►

Sign in to add a comment