Issue metadata
Sign in to add a comment
|
448kb regression in sizes at 572124:572124 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jul 3
Assigning to sheriff gbiv@chromium.org because this autoroll is the only CL in range: Roll AFDO from 69.0.3479.0_rc-r1 to 69.0.3480.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I8dfa0e2421a7c9142bc0a0381be714acfe2faab0 Reviewed-on: https://chromium-review.googlesource.com/1124101 Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572124}
,
Jul 9
Looks like the roll in r572724 won us this binary size back. For context, AFDO profiles are generated by sampling Chrome's execution and feeding that back into the compiler, so the compiler can better optimize Chrome. This process is inherently noisy, so we’ll sometimes see Chrome vary in size as the inliner decides to be more/less aggressive. Denoising this is being tracked in issue 849881. This graph looks pretty bumpy recently (e.g. within the last week) though. If I see many more complaints back-to-back like this, I'm going to figure out what's going on. If not, we should hopefully have a more stable source of profiles soon... |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jul 3