New issue
Advanced search Search tips

Issue 859910 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0 failing on chromium.mac/ios-simulator-full-configs

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jul 3

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of mahmadi@chromium.org

ios_chrome_web_egtests (iPad Air 2 iOS 10.3) shard 0 failing on chromium.mac/ios-simulator-full-configs

Builders failed on: 
- ios-simulator-full-configs: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-simulator-full-configs


 
Owner: eugene...@chromium.org
Hi Eugene, ErrorPageTestCase/testRendererInitiatedGoBackFromErrorPageAndForwardToErrorPage seems to be flaky. Could you please investigate?

Cc: spqchan@google.com
 Issue 860083  has been merged into this issue.
Components: Infra>Client>iOS
Status: Assigned (was: Available)
It still looks failing frequently.
Could you disable the test first?
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86a901338e88829f4f46243cfecdd07f6bc4f0e2

commit 86a901338e88829f4f46243cfecdd07f6bc4f0e2
Author: Ella Ge <eirage@chromium.org>
Date: Thu Jul 05 19:56:44 2018

Disable testRendererInitiatedGoBackFromErrorPageAndForwardToErrorPage

disable test:
ErrorPageTestCase/testRendererInitiatedGoBackFromErrorPageAndForwardToErrorPage

TBR=eugenebut@chromium.org

Bug:  859910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I082a0279e365d2f53179aad1d9f6eaf50b3665c4
Reviewed-on: https://chromium-review.googlesource.com/1127260
Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572843}
[modify] https://crrev.com/86a901338e88829f4f46243cfecdd07f6bc4f0e2/ios/chrome/browser/web/error_page_egtest.mm

Cc: eugene...@chromium.org
 Issue 860628  has been merged into this issue.
Labels: -Sheriff-Chromium
Failure log:

Test Case '-[ErrorPageTestCase testRendererInitiatedGoBackFromErrorPageAndForwardToErrorPage]' started.
[0703/183504.947135:WARNING:embedded_test_server.cc(229)] Request not handled. Returning 404: /favicon.ico
[0703/183508.135189:FATAL:crw_web_controller.mm(1702)] Check failed: error.
0   ios_chrome_web_egtests              0x0000000107f2488d base::debug::StackTrace::StackTrace(unsigned long) + 157
1   ios_chrome_web_egtests              0x0000000107f248cd base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_web_egtests              0x0000000107c3287c base::debug::StackTrace::StackTrace() + 28
3   ios_chrome_web_egtests              0x0000000107c78d6c logging::LogMessage::~LogMessage() + 460
4   ios_chrome_web_egtests              0x0000000107c76bd5 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_web_egtests              0x0000000106880f5e -[CRWWebController loadErrorPageForNavigationItem:navigationContext:] + 366
6   ios_chrome_web_egtests              0x000000010688349f -[CRWWebController handleErrorRetryCommand:navigationItem:navigationContext:] + 639
7   ios_chrome_web_egtests              0x00000001068abe56 -[CRWWebController webView:didFinishNavigation:] + 3718
8   WebKit                              0x000000011654cd15 WebKit::NavigationState::NavigationClient::didFinishNavigation(WebKit::WebPageProxy&, API::Navigation*, API::Object*) + 91
9   WebKit                              0x0000000116688d08 WebKit::WebPageProxy::didFinishLoadForFrame(unsigned long long, unsigned long long, WebKit::UserData const&) + 312
10  WebKit                              0x00000001166a351b void IPC::handleMessage<Messages::WebPageProxy::DidFinishLoadForFrame, WebKit::WebPageProxy, void (WebKit::WebPageProxy::*)(unsigned long long, unsigned long long, WebKit::UserData const&)>(IPC::Decoder&, WebKit::WebPageProxy*, void (WebKit::WebPageProxy::*)(unsigned long long, unsigned long long, WebKit::UserData const&)) + 100
11  WebKit                              0x0000000116549965 IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) + 127
12  WebKit                              0x00000001166e9cd8 WebKit::WebProcessProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 24
13  WebKit                              0x00000001165114e3 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 119
14  WebKit                              0x0000000116513bd8 IPC::Connection::dispatchOneMessage() + 176

Project Member

Comment 9 by bugdroid1@chromium.org, Jul 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3dde9c4dda09e8a91b2d9786e40e91439fe0cb5

commit f3dde9c4dda09e8a91b2d9786e40e91439fe0cb5
Author: Eugene But <eugenebut@google.com>
Date: Tue Jul 10 19:10:54 2018

Correctly disable testRendererInitiatedGoBackFromErrorPageAndForwardToErrorPage.

Flaky tests shoild be disabled with FLAKY_ prefix. This way the tests
still run, bug do not close the tree.


TBR=eirage@chromium.org

Bug:  859910 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id5de49a341a9e249b03b724773d8d7681daf37c1
Reviewed-on: https://chromium-review.googlesource.com/1131927
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573849}
[modify] https://crrev.com/f3dde9c4dda09e8a91b2d9786e40e91439fe0cb5/ios/chrome/browser/web/error_page_egtest.mm

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bd13b06dfd2fe72965e80597a58294ba12f811b

commit 2bd13b06dfd2fe72965e80597a58294ba12f811b
Author: Eugene But <eugenebut@chromium.org>
Date: Mon Oct 22 16:17:10 2018

Remove kWebErrorPages flag.

Notable changes:
  - removed redundant tests from ErrorPageTestCase
    (error_page_inttest cover these cases)
  - removed ErrorPageGenerator class
  - removed ErrorPageContent class
  - removed code which shows alert for non-printable
    pages

Bug:  725241 ,  694662 ,  840489 ,  859910 
Change-Id: I0cad718200a3682633c0babf9b57b45cff39a579
Reviewed-on: https://chromium-review.googlesource.com/c/1289995
Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601604}
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/prerender/preload_controller.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/activity_services/activity_service_controller_egtest.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/ui/browser_view_controller_unittest.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/web/BUILD.gn
[delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_content.h
[delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_content.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/chrome/browser/web/error_page_egtest.mm
[delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator.h
[delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator.mm
[delete] https://crrev.com/4676d794a8801cd5ae31b745ee124431d174f688/ios/chrome/browser/web/error_page_generator_unittest.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/features.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine.h
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/navigation/error_retry_state_machine_unittest.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/features.h
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/test/fakes/test_native_content_provider.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/public/web_state/ui/crw_native_content_provider.h
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/error_page_inttest.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/ui/crw_web_controller.mm
[modify] https://crrev.com/2bd13b06dfd2fe72965e80597a58294ba12f811b/ios/web/web_state/web_state_observer_inttest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment