New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859904 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 12
Components:
EstimatedDays: 5
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Ad filtering / abusive enforcement should trigger only for first and last sites in redirect chain.

Project Member Reported by ericrobinson@chromium.org, Jul 3

Issue description

See also crbug/823414.

This is an update to this issue to ignore entries in the middle of the redirect chain, and consider only the first and last entries in that chain for ad filtering / abusive enforcement.
 
Status: Fixed (was: Untriaged)
Closing this bug but reporting percentages for this metric prior to the change, so including "any middle" triggers:

For the pop-up blocker:
6.12% triggered by first URL.
1.05% triggered by any middle URL.
1.08% triggered by last URL.
Rest of occurrences were single-URL.

For safebrowsing:
4.22% triggered by first URL.
1.89% triggered by any middle URL.
19.80% triggered by last URL.
Rest of occurrences were single-URL.

Project Member

Comment 3 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89e1edce1678acabe1f713c5e18902c0b4995add

commit 89e1edce1678acabe1f713c5e18902c0b4995add
Author: Eric Robinson <ericrobinson@chromium.org>
Date: Thu Jul 19 16:09:39 2018

Turn off redirect feature.

We are turning off this feature until our framework for detecting if a site is
commonly visited also includes redirects as well.  Worry if a common redirecter
makes it on to our black list, then we would end up blocking all navigations
through that redirecter.

Bug:  859904 
Change-Id: I02bb128a422cfce354d83326efc677eb9a8c7462
Reviewed-on: https://chromium-review.googlesource.com/1142038
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576515}
[modify] https://crrev.com/89e1edce1678acabe1f713c5e18902c0b4995add/chrome/browser/ui/blocked_content/safe_browsing_triggered_popup_blocker_unittest.cc
[modify] https://crrev.com/89e1edce1678acabe1f713c5e18902c0b4995add/components/subresource_filter/core/browser/subresource_filter_features.cc

Sign in to add a comment