New issue
Advanced search Search tips

Issue 859895 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 0
Type: Bug



Sign in to add a comment

app-emulation/lxd package breaking build intermittently

Project Member Reported by mortonm@chromium.org, Jul 3

Issue description

build_packages step for app-emulation/lxd package on tatl board seems flaky, as it has broken the build and caused 3 CQ runs (https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?builderName=tatl-paladin&buildNumber=3940) to fail in the last ~12 hours with this failure:

lxd-2.21-r2: # github.com/lxc/lxd/vendor/gopkg.in/lxc/go-lxc.v2
lxd-2.21-r2: In file included from src/github.com/lxc/lxd/vendor/gopkg.in/lxc/go-lxc.v2/container.go:11:
lxd-2.21-r2: ./lxc-binding.h:95:8: error: redefinition of 'migrate_opts'
lxd-2.21-r2: struct migrate_opts {
lxd-2.21-r2:        ^
lxd-2.21-r2: ../../../../../../../../../../../../../../usr/include/lxc/lxccontainer.h:908:8: note: previous definition is here
lxd-2.21-r2: struct migrate_opts {
lxd-2.21-r2:        ^
lxd-2.21-r2: 1 error generated.

Not sure if this recent CL could be the cause: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1103613

 
Labels: -Pri-1 Pri-0
Cc: mortonm@chromium.org
Status: Started (was: Untriaged)
I think we need LXD 3.0.0's ebuild to land since it depends on LXC 3.0.0. I'm not sure why this is flaky (vs failing outright) though.

mortonm@ please mark tatl-paladin as experimental. I don't know if we can safely revert LXC to version 2 since both moblab and some infra stuff depend on it.
go-lxc will be built against LXC. This to me looks like either the LXC header file is advocating the wrong version number which would be very odd. Or you need to make sure that you're using the newest go-lxc version.

#if !VERSION_AT_LEAST(2, 0, 0)
struct migrate_opts {
	char *directory;
	bool verbose;
	bool stop;
	char *predump_dir;
};
#endif

Status: Fixed (was: Started)
LXD 3.0.0 has landed with the version of go-lxc to match. termina builders are green.
https://uberchromegw.corp.google.com/i/chromiumos/builders/tatl-paladin
https://uberchromegw.corp.google.com/i/chromiumos/builders/tael-paladin

Sign in to add a comment