New issue
Advanced search Search tips

Issue 859879 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[css-logical] -webkit- logical sizing properties should be aliases

Project Member Reported by obru...@igalia.com, Jul 3

Issue description

What steps will reproduce the problem?

Chromium implements standard logical sizing properties and -webkit- prefixed ones independently, not as aliases. For example, this implies that  issue 849855  was fixed for block-size and inline-size, but -webkit-logical-height and -webkit-logical-width are still affected.

What is the expected result?

Prefixed properties should be aliases of the standard ones:
  -webkit-logical-height --> block-size
  -webkit-min-logical-height --> min-block-size
  -webkit-max-logical-height --> max-block-size
  -webkit-logical-width --> inline-size
  -webkit-min-logical-width --> min-inline-size
  -webkit-max-logical-width --> max-inline-size

What happens instead?

They are not aliases. -webkit-logical-height and -webkit-logical-width should not be affected by  issue 849855 .


 
Status: Available (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/425106d9525007f9c2c4296e5bdc17124836214f

commit 425106d9525007f9c2c4296e5bdc17124836214f
Author: Oriol Brufau <obrufau@igalia.com>
Date: Thu Jul 05 19:11:03 2018

[css-logical] Alias -webkit- logical sizing properties to standard ones

They were implemented as independent properties that behave identically,
except that  issue 849855  was only fixed for the standard ones.

BUG= 859879 

Change-Id: Ibc533cdc8a35b4f2d3e680a334369ddeafc427be
Reviewed-on: https://chromium-review.googlesource.com/1124844
Reviewed-by: Anders Ruud <andruud@chromium.org>
Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Manuel Rego Casasnovas <rego@igalia.com>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#572837}
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/WebKit/LayoutTests/virtual/stable/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/WebKit/LayoutTests/webexposed/css-property-listing-expected.txt
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/blink/renderer/core/css/BUILD.gn
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_logical_height_custom.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_logical_width_custom.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_max_logical_height_custom.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_max_logical_width_custom.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_min_logical_height_custom.cc
[delete] https://crrev.com/c53c6095ca8c16d2ef2cc0057fe91ae0828c0572/third_party/blink/renderer/core/css/properties/longhands/webkit_min_logical_width_custom.cc
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/third_party/blink/renderer/core/frame/use_counter.cc
[modify] https://crrev.com/425106d9525007f9c2c4296e5bdc17124836214f/tools/metrics/histograms/enums.xml

Status: Fixed (was: Available)

Sign in to add a comment