New issue
Advanced search Search tips

Issue 859876 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Check failed: IsBound() in SessionStorageAreaImpl

Project Member Reported by dullweber@chromium.org, Jul 3

Issue description

Chrome Version: http://crrev.com/571892
OS: Linux

A DCHECK in SessionStorageAreaImpl fails when deleting Cookies from Clear Browsing Data.

Steps:
1. visit example.com
2. execute "sessionStorage.setItem(1,2)" in console
4. Go to clear browsing data
5. Close the example.com tab
5. Delete cookies

[250423:250438:0703/154214.590671:FATAL:session_storage_area_impl.cc(97)] Check failed: IsBound(). 
#0 0x7f93039603cc base::debug::StackTrace::StackTrace()
#1 0x7f93038a81cb logging::LogMessage::~LogMessage()
#2 0x7f9300da7d74 content::SessionStorageAreaImpl::DeleteAll()
#3 0x7f9300dbab7c content::SessionStorageNamespaceImplMojo::RemoveOriginData()
#4 0x7f9303888dfd base::debug::TaskAnnotator::RunTask()

 
Owner: dmu...@chromium.org
dmurph@ - can you take a peek?
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/baa43bde019b304847c07b5505c934ddab97de5a

commit baa43bde019b304847c07b5505c934ddab97de5a
Author: Daniel Murphy <dmurph@chromium.org>
Date: Mon Jul 09 22:40:47 2018

[SessionStorage] Fixed Clear Browsing Data Dialog data deletion

When using the Clear Browsing Dialog, this can call a DeleteAll in
SessionStorage backend code. There were DCHECKs around being bound to
a renderer, but this doesn't need to be the case when using the Clear
Browsing Data Dialog.

This CL removes those DCHECKs for DeleteAll.

R=mek@chromium.org

Bug:  859876 
Change-Id: Iee4e3027ad1a1c396f1b7f746aec0e844a8f64b1
Reviewed-on: https://chromium-review.googlesource.com/1125023
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573494}
[modify] https://crrev.com/baa43bde019b304847c07b5505c934ddab97de5a/content/browser/dom_storage/session_storage_area_impl.cc
[modify] https://crrev.com/baa43bde019b304847c07b5505c934ddab97de5a/content/browser/dom_storage/session_storage_area_impl_unittest.cc
[modify] https://crrev.com/baa43bde019b304847c07b5505c934ddab97de5a/content/browser/dom_storage/session_storage_namespace_impl_mojo_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment