New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859866 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 4
Cc:
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 851433



Sign in to add a comment

Do not hardcode always enabled types into settings

Project Member Reported by vitaliii@chromium.org, Jul 3 
Always-enabled user types need to be hardcoded into settings code:

https://cs.chromium.org/chromium/src/components/sync/base/sync_prefs.cc?q=" == DEVICE_INFO"&sq=package:chromium&dr=C

This feels odd because we have ModelType sets for everything else in model_type.h (including user selectable types). WE should either add a new model type set or infer it from existing ones.

Comment 1 by jkrcal@chromium.org, Jul 4 

Vitalii, to clarify the bug, is it just DEVICE_INFO that gets special treatment in sync_prefs.cc?

Comment 2 by vitaliii@chromium.org, Jul 4

Status: Fixed (was: Untriaged)
Nope, USER_CONSENTS as well.
Actually, I did create a set (AlwaysPreferredUserTypes) already in https://chromium-review.googlesource.com/c/chromium/src/+/1124330.
Thus, technically this bug is fixed. However, I am not happy with existing sets. I feel like AlwaysPreferredUserTypes can be inferred and there are at least one odd comment ("and include ControlTypes()" about core types), I filled issue 860244 for this.
►

Sign in to add a comment