New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859859 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[USS] Improve metrics for launching further USS types

Project Member Reported by jkrcal@chromium.org, Jul 3

Issue description

We lack some key metrics for assessing launching USS implementations for further model types:

A) Fix Sync.ModelTypeCount.* metric 
 - Currently, it is recorded for directory even for disabled types and not recorded for any USS type.
 - We need to stop recording it for disabled directory types and start recording it equivalently for enabled USS types.
 - If equivalent recording is complicated, we can replace the metric by another metric for both directory and USS - do it at the same time as Sync.ModelTypeMemoryKB.* metrics.


B) Add Sync Engine metrics here (or somewhere close):
https://cs.chromium.org/chromium/src/components/sync/engine_impl/syncer.cc?l=160&rcl=5e4aae833c2dc4e398896ced1cefd65eac7bd4b4)

Option 1:
 - a histogram for each type with buckets for counting commits to the server:
   - local deletions (tombstones)
   - local creations (server version == 0)
   - local updates (other commits)
 - a histogram for each type with buckets for counting updates from the server:
   - remote deletions
   - remote updates

Option 2: like 1, uplink and downlink stored to only one histogram per data type (with 5 buckets).
 
Labels: sync-fixit-2018q3
Cc: pav...@chromium.org
 Issue 750838  has been merged into this issue.
Owner: jkrcal@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46f1aef7c53463fb8cc5f5e36d728f9640e40a94

commit 46f1aef7c53463fb8cc5f5e36d728f9640e40a94
Author: Jan Krcal <jkrcal@chromium.org>
Date: Mon Jul 09 17:21:14 2018

[Sync UMA] Make CommitCounters more fine-grained

This CL makes CommitCounters in the sync engine distinguish creations,
deletions, and updates. The CL displays the detailed counters in
chrome://sync-internals. The main purpose of this CL is though to
make these fine-grained counters available for recording to UMA.

Bug:  859859 
Change-Id: I6d6694365dcafd620984bfbaddb2f05c435f8e3a
Reviewed-on: https://chromium-review.googlesource.com/1128960
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573349}
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/driver/resources/types.html
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine/cycle/commit_counters.cc
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine/cycle/commit_counters.h
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine_impl/directory_commit_contribution.cc
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine_impl/model_type_worker_unittest.cc
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine_impl/non_blocking_type_commit_contribution.cc
[modify] https://crrev.com/46f1aef7c53463fb8cc5f5e36d728f9640e40a94/components/sync/engine_impl/syncer_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f

commit 75bb0d02e645fb3a93511fafd3574c8a9f7bf05f
Author: Jan Krcal <jkrcal@chromium.org>
Date: Tue Jul 24 17:12:33 2018

[UMA] Record entity changes in DataTypeDebugInfoEmitter

This CL introduces new UMA histograms that record types of commits and
updates processed by the sync engine. For each datatype there is a
separate histogram so that the data can indicate bugs or regression in
individual data types.

Bug:  859859 
Change-Id: Iaeaa7a657ebe7d9d6fbbd329152162c5acaadc01
Reviewed-on: https://chromium-review.googlesource.com/1131507
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577592}
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/BUILD.gn
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/base/data_type_histogram.cc
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/base/model_type.h
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/engine_impl/cycle/data_type_debug_info_emitter.cc
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/engine_impl/cycle/data_type_debug_info_emitter.h
[add] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/engine_impl/cycle/data_type_debug_info_emitter_unittest.cc
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/components/sync/syncable/model_type.cc
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/75bb0d02e645fb3a93511fafd3574c8a9f7bf05f/tools/metrics/histograms/histograms.xml

Project Member

Comment 6 by bugdroid1@chromium.org, Jul 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f42aa9750b2393a344dfdea75a34d1e815ae2774

commit f42aa9750b2393a344dfdea75a34d1e815ae2774
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Jul 26 08:38:20 2018

[Sync UMA] Record data type counts consistently in Directory&USS

This CL replaces the inconsistently recorded metrics
Sync.ModelTypeCount.* by new metrics Sync.ModelTypeCount2.* The new
metrics are recorded for both USS and Directory and also at the same
time (after sync configuration).

Bug:  859859 
Change-Id: Ib21ab1d2fda24beb824509918ce512b4d214ee3e
Reviewed-on: https://chromium-review.googlesource.com/1131747
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578241}
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/base/data_type_histogram.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/base/data_type_histogram.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/data_type_controller.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/directory_data_type_controller.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/directory_data_type_controller.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/model_type_controller.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/model_type_controller.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/model_type_controller_unittest.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/proxy_data_type_controller.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/driver/proxy_data_type_controller.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/model/fake_model_type_controller_delegate.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/model/fake_model_type_controller_delegate.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/model/model_type_controller_delegate.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/model_impl/client_tag_based_model_type_processor.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/model_impl/client_tag_based_model_type_processor.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/syncable/directory.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/syncable/directory.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/syncable/directory_backing_store.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync/syncable/syncable_id.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync_bookmarks/bookmark_model_type_processor.cc
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/components/sync_bookmarks/bookmark_model_type_processor.h
[modify] https://crrev.com/f42aa9750b2393a344dfdea75a34d1e815ae2774/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Hurray! :)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/329857de3b097d38a171336b14460809b3a93e53

commit 329857de3b097d38a171336b14460809b3a93e53
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Aug 30 21:58:29 2018

[USS] Fix reporting of entities counts for USS data types

This CL fixes a bug in reporting counts of sync entities for USS data
types (introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1131747).

Previously, also tombstones were recorded as entities which were not
recorded for directory data types. After this CL, only non-deleted
entities are consistently recorded for all data types.

Bug:  859859 
Change-Id: I8ee885ca6901f77feba6c5e8420b28a4b9bf8ce6
Reviewed-on: https://chromium-review.googlesource.com/1196449
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587801}
[modify] https://crrev.com/329857de3b097d38a171336b14460809b3a93e53/components/sync/base/data_type_histogram.cc
[modify] https://crrev.com/329857de3b097d38a171336b14460809b3a93e53/components/sync/model_impl/client_tag_based_model_type_processor.cc
[modify] https://crrev.com/329857de3b097d38a171336b14460809b3a93e53/tools/metrics/histograms/histograms.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/845293f2103b8eeecad5a5136a0052e87bfbba74

commit 845293f2103b8eeecad5a5136a0052e87bfbba74
Author: Jan Krcal <jkrcal@chromium.org>
Date: Wed Sep 26 05:37:21 2018

[USS] Fix reporting of entities counts for Directory data types

This CL fixes a bug in reporting counts of sync entities for Directory
data types (introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1131747).

Previously, also the root node was recorded for directory data types.
There is no root node in USS data types so it is not recorded. After
this CL, only non-root entities are consistently recorded for all data
types.


Bug:  859859 
Change-Id: Ic500dfc2b0976edd97975e115a399f1f23292da0
Reviewed-on: https://chromium-review.googlesource.com/1243112
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594227}
[modify] https://crrev.com/845293f2103b8eeecad5a5136a0052e87bfbba74/components/sync/base/data_type_histogram.cc
[modify] https://crrev.com/845293f2103b8eeecad5a5136a0052e87bfbba74/components/sync/driver/directory_data_type_controller.cc
[modify] https://crrev.com/845293f2103b8eeecad5a5136a0052e87bfbba74/tools/metrics/histograms/histograms.xml

Sign in to add a comment