Regression:Focus is not seen on the 'x' button on pressing tab on Print overlay
Reported by
vineetha...@etouch.net,
Jul 3
|
||||
Issue descriptionChrome Version: 69.0.3480.0(Official Build) Revision 3c4342c43a5e8e33042613038d4777cc1c9349af-refs/branch-heads/3480@{#1}(32/64 bit) OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04) OS Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch Chrome open NTP and give print command using 'Ctrl+P' to open Print Preview overlay. (2) Click on 'Change' button to open 'Select a destination' overlay. (3) Now press tab and observe the focus. Actual Result: Focus is not seen on the 'x' button on pressing tab. Expected Result: Focus should be seen on the 'x' button on pressing tab. This is regression issue broken in ‘M-67’ and providing the bisect using per-revision bisect, Good build: 67.0.3368.0(Revision: 542341) Bad build : 67.0.3369.0(Revision: 542817) You are probably looking for a change made after 542361 (known good), but no later than 542362 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/feb3b5d8fc0436f4ae83736f450544142e9a21f1..b6477fef9acbe00a3e8b58b6963b518b57575ed3 Suspect: https://chromium.googlesource.com/chromium/src/+/b6477fef9acbe00a3e8b58b6963b518b57575ed3 @hcarmona: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Jul 3
Repeating our chat discussion here. Having the 'x' button not be in the tab order is not a11y friendly, so I don't think we need to repeat that behavior. Moreover, the 'x' button could fully go away once/if we migrate Print preview to MD.
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef3275516a50e3f2af82d116b1d77cd65d3a2f83 commit ef3275516a50e3f2af82d116b1d77cd65d3a2f83 Author: rbpotter <rbpotter@chromium.org> Date: Tue Jul 10 00:42:44 2018 cr-dialog close buttons: Allow custom appearance when focused Allow elements that use cr-dialog to override the appearance of the close button when it is focused. Bug: 859857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Id13b83ad9653149e0a81b2b23fe6af62ee349669 Reviewed-on: https://chromium-review.googlesource.com/1125289 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#573561} [modify] https://crrev.com/ef3275516a50e3f2af82d116b1d77cd65d3a2f83/chrome/browser/resources/print_preview/new/search_dialog_css.html [modify] https://crrev.com/ef3275516a50e3f2af82d116b1d77cd65d3a2f83/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
Jul 10
Update : Rechecked the above issue on Windows(7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04) OS with latest Canary Chrome version #69.0.3487.0 and the issue is fixed. Kindly refer the attached screen cast.
,
Jul 10
|
||||
►
Sign in to add a comment |
||||
Comment 1 by rbpotter@chromium.org
, Jul 3Owner: rbpotter@chromium.org