New issue
Advanced search Search tips

Issue 859855 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jul 9
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Duplicated IDR_PDF_COMPOSITOR_MANIFEST

Reported by sabbaku...@yandex-team.ru, Jul 3 
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 YaBrowser/18.7.0.1428 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
IDR_PDF_COMPOSITOR_MANIFEST resource is in headless/lib/resources/headless_lib_resources.grd and chrome/browser/browser_resources.grd.

What is the expected behavior?

What went wrong?
If grit_predetermined_resource_ids_file defined in tools/grit/grit_rule.gni contains IDR_PDF_COMPOSITOR_MANIFEST it causes a compilation error (duplication ids).

Did this work before? N/A 

Chrome version: 67.0.3396.87  Channel: n/a
OS Version: 10.0
Flash Version: Shockwave Flash 30.0 r0

Comment 1 by krajshree@chromium.org, Jul 4

Components: Platform>DevTools
Labels: Triaged-ET TE-NeedsTriageHelp Needs-Triage-M67
The issue seems to be out of TE-scope as it is related to IDR_PDF_COMPOSITOR_MANIFEST resource. Hence, adding label TE-NeedsTriageHelp for further investigation from dev team.

Thanks...!!
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b697ebe8c7fa41af015d191654785924d156b65

commit 1b697ebe8c7fa41af015d191654785924d156b65
Author: Sergey Abbakumov <sabbakumov@yandex-team.ru>
Date: Fri Jul 06 13:29:28 2018

Remove duplicated IDR_PDF_COMPOSITOR_MANIFEST

IDR_PDF_COMPOSITOR_MANIFEST resource is in
headless/lib/resources/headless_lib_resources.grd and
chrome/browser/browser_resources.grd.  If
grit_predetermined_resource_ids_file defined in tools/grit/grit_rule.gni
contains IDR_PDF_COMPOSITOR_MANIFEST it causes a compilation error
(duplication ids).

Bug:  859855 
Change-Id: Ia6d204c7d718b297150335b2c8eddad6abc140d6
Reviewed-on: https://chromium-review.googlesource.com/1124460
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572951}
[modify] https://crrev.com/1b697ebe8c7fa41af015d191654785924d156b65/headless/lib/resources/headless_lib_resources.grd

Comment 3 by paulir...@chromium.org, Jul 9

Components: -Platform>DevTools Internals>Headless
Status: Fixed (was: Unconfirmed)
fixed?

Comment 4 by sabbaku...@yandex-team.ru, Jul 10 

Yes, the issue is fixed.
►

Sign in to add a comment