New issue
Advanced search Search tips

Issue 859848 link

Starred by 1 user
Status: Fixed
Owner:
afakhry@chromium.org
Closed: Jul 4
Cc:
ajha@chromium.org
ovanieva@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
nightlight



Sign in to add a comment

Non-Regression: On clicking on Night Light icon or 'Night Light' text just enable/disable the Night Light instead nightlight section menu can be displayed

Project Member Reported by rkalavakuntla@chromium.org, Jul 3 
Chrome Version:69.0.3479.0/10840.0.0 dev channel Candy, Blaze & Peppy
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign into user >> Go to ubertray
(2)Click on Night Light icon and observe
(3)Now click on 'Night Light' text below the icon and observe

Actual: On clicking on Night Light icon or text just enable/disable the Night Light
Expected: Instead, on clicking 'Night Light' text it can redirect to Night Light section that has Color temperature adjustments,Schedule menu options (that will be in chrome://settings/display >>Night Light section)

This as a Non-Regression seen from M-69

Attached the screencast for reference..
Actual.mp4
7.1 MB View Download

Comment 1 by afakhry@chromium.org, Jul 3

Cc: -afakhry@chromium.org ovanieva@chromium.org
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
This is a new feature in the new tray that we didn't have before.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bc2788a9ed728812af1c7dfec1349bd1b2658e0

commit 4bc2788a9ed728812af1c7dfec1349bd1b2658e0
Author: Ahmed Fakhry <afakhry@google.com>
Date: Wed Jul 04 00:58:13 2018

Night Light unified tray label behavior

Rather than toggling Night Light on or off, clicking
the label should take the user to the display settings
page where Night Light can be adjusted.

BUG= 859848 
TEST=Manually

Change-Id: Ic1f15c6c953bfc8a38f94a7015dc7a3b877c404b
Reviewed-on: https://chromium-review.googlesource.com/1125338
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572417}
[modify] https://crrev.com/4bc2788a9ed728812af1c7dfec1349bd1b2658e0/ash/system/night_light/night_light_feature_pod_controller.cc
[modify] https://crrev.com/4bc2788a9ed728812af1c7dfec1349bd1b2658e0/ash/system/night_light/night_light_feature_pod_controller.h
[modify] https://crrev.com/4bc2788a9ed728812af1c7dfec1349bd1b2658e0/ash/system/unified/unified_system_tray_controller.cc

Comment 3 by afakhry@chromium.org, Jul 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment