New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859837 link

Starred by 2 users
Status: WontFix
Owner:
█ kraynov@chromium.org
Xoogler
Closed: Oct 3
Cc:
eseckler@chromium.org
skyos...@chromium.org
altimin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Ensure minimal external exposure of //base/task/sequence_manager

Project Member Reported by kraynov@chromium.org, Jul 3 
Once scheduler/base move is complete, do the following:
1. Remove unnecessary BASE_EXPORT macros.
2. Ensure no code outside //base/task/sequence_manager uses anything in the internal namespace.
3. Narrow down DEPS rules for using SequenceManager in blink scheduler.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/410d3d75c58860d371551c79045f35b7b277a183

commit 410d3d75c58860d371551c79045f35b7b277a183
Author: Greg Kraynov <kraynov@chromium.org>
Date: Wed Jul 11 11:27:46 2018

Remove redundant SequenceManager includes and enforce DEPS.

Bug:  859837 
Change-Id: I1bc8a175055ddd5400a96ac97c86f2d71539e9f6
Reviewed-on: https://chromium-review.googlesource.com/1131934
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Greg Kraynov <kraynov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574126}
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/DEPS
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/common/scheduler_helper.cc
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/common/throttling/budget_pool_unittest.cc
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/main_thread/DEPS
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_task_queue.cc
[add] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/test/DEPS
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/worker/DEPS
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.cc
[modify] https://crrev.com/410d3d75c58860d371551c79045f35b7b277a183/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_task_queue.h

Comment 2 by kraynov@chromium.org, Jul 18

Cc: eseckler@chromium.org
The only remaining part is TaskQueueImpl references from the renderer-specific task queues.

Comment 3 by altimin@chromium.org, Aug 15

Labels: -Type-Bug -Pri-2 Pri-3 Type-Feature

Comment 4 by altimin@chromium.org, Aug 15

Labels: -Type-Feature Type-Task

Comment 5 by kraynov@chromium.org, Oct 3

Status: WontFix (was: Assigned)
Will be automatically resolved after TaskQueue ownership refactoring
►

Sign in to add a comment