New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 859831 link

Starred by 3 users
Status: Fixed
Owner:
tetsui@chromium.org
Closed: Jul 18
Cc:
omrilio@chromium.org
ajha@chromium.org
yamaguchi@chromium.org
tetsui@chromium.org
█ yoshiki@chromium.org
chrome-os-gcon-escalation@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Do not Disturb is getting turned ON automatically when clicked on Notification text in Ubertray

Project Member Reported by kebalaji@chromium.org, Jul 3 
Chrome Version:  69.0.3479.0/10840.0.0  dev channel  Candy, Reks, Blaze & Peppy
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Click on Ubertray, then on Notification Text and observe

Actual: Do not Disturb is getting turned ON automatically when clicked on Notification text
Expected: No such issue should be seen 

This is a Regression issue as same is working fine in 69.0.3476.0/10832.0 dev
ActualDND.webm
216 KB View Download
ExpectedDND.webm
910 KB View Download

Comment 1 by yoshiki@chromium.org, Jul 3

Owner: tetsui@chromium.org
Status: Assigned (was: Untriaged)
Tetsui-san, could you take a look?

Comment 2 by yoshiki@chromium.org, Jul 3 

I confirmed this on ToT. Perhaps this might be an intended behavior. Tetsui-san, please take a look. Thanks.

Comment 3 by tetsui@chromium.org, Jul 3

Cc: omrilio@chromium.org
This is an intended behavior mentioned by omrilio@ but probably it's better to not do this for Do not disturb.
+omrilio@ WDYT?

Comment 4 by aidrees@google.com, Jul 3

Labels: Hotlist-ConOps-CrOS

Comment 5 by tetsui@chromium.org, Jul 17 

Issue 863622 has been merged into this issue.

Comment 6 by tetsui@chromium.org, Jul 17

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe7b0602d87ac8abdc06590e02300218197cd916

commit fe7b0602d87ac8abdc06590e02300218197cd916
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Jul 18 06:23:25 2018

Unified: Fix DND and network button behavior.

This CL fixes two issues:
* Fix do-not-disturb button to turn on DND automatically on the label
  click.
* Fix network button to ignore the icon click when Ethernet is
  connected.

TEST=manual
BUG= 859831 , 861709 

Change-Id: I064db9687084ac21aa9a059b7cd90f740e734d4d
Reviewed-on: https://chromium-review.googlesource.com/1139849
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575957}
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/network/network_feature_pod_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/quiet_mode_feature_pod_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_controller.cc
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_controller.h
[modify] https://crrev.com/fe7b0602d87ac8abdc06590e02300218197cd916/ash/system/unified/unified_system_tray_test_api.cc

Comment 8 by tetsui@chromium.org, Jul 18

Status: Fixed (was: Started)

Comment 9 by tetsui@chromium.org, Jul 20

Cc: yamaguchi@chromium.org
 Issue 865233  has been merged into this issue.
►

Sign in to add a comment