New issue
Advanced search Search tips

Issue 859830 link

Starred by 1 user
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Jul 3
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Keyboard shortcut 'Ctrl + Shift + Q' is not seen besides 'Exit' option in wrench menu list.

Reported by rp...@etouch.net, Jul 3 
Version: 69.0.3480.0 (Official Build)Revision 3c4342c43a5e8e33042613038d4777cc1c9349af-refs/branch-heads/3480@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10) and Linux (14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome,click on 'Avatar' icon and then click on 'Open Guest window'
2. Now click on 'Customize and control Google Chrome' and observe 'Exit' option in wrench menu list
 
Actual: Keyboard shortcut 'Ctrl + Shift + Q' is not seen besides 'Exit' option in wrench menu list
Expected: Keyboard shortcut 'Ctrl + Shift + Q' should be seen besides 'Exit' option in wrench menu list

This is regression issue, broken in ‘M 69’ and below is the bisect info :
Good build: 69.0.3466.0  (Revision: 568695).
Bad build: 69.0.3469.3 (Revision: 569382).

You are probably looking for a change made after 568886 (known good), but no later than 568898 (first known bad).

Narrow Bisect info : 
https://chromium.googlesource.com/chromium/src/+log/db53bdce09655a51dc7b6be71e928c5afadf63ee..a0c9298d9d825c612b2e5e5ba606e57f1ec91c6d?pretty=fuller&n=50

Suspecting: r568887 from Narrow bisect

@thomasanderson: Could you please help to reassign if your change is not the cause for this change.

Note:
1.Unable to provide bisect using per-revision script,Hence providing bisect with old script.
2.This issue is also reproducible on M-69 Dev (build # 69.0.3472.3)
3.Issue is not seen on Mac(10.12.6,10.13.1,10.13.6)
Actual_video.mp4
220 KB View Download
Expected_video.mp4
208 KB View Download
Actual_screenshot.png
75.7 KB View Download
Expected_screenshot.png
77.7 KB View Download

Comment 1 by thomasanderson@chromium.org, Jul 3

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e7df4af1c1f027ec01de682c705cd4da84aa4cd

commit 7e7df4af1c1f027ec01de682c705cd4da84aa4cd
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Jul 03 22:15:04 2018

Add Ctrl+Shift+Q exit accelerator back

Though the accelerator is now handled by ConfirmQuitBubbleController, we still
need the accelerator entry for showing the accelerator subtext in the menu on
the Exit entry.

BUG= 859830 
R=pkasting

Change-Id: Ia5f40482b009619d0cb44d5b05b9592b7fb13700
Reviewed-on: https://chromium-review.googlesource.com/1125082
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572370}
[modify] https://crrev.com/7e7df4af1c1f027ec01de682c705cd4da84aa4cd/chrome/browser/ui/views/accelerator_table.cc

Comment 3 by thomasanderson@chromium.org, Jul 3

Status: Fixed (was: Started)

Comment 4 by rp...@etouch.net, Jul 4

Labels: TE-Verified-69.0.3481.0 TE-Verified-M69
Update:-
Re-tested this issue on Windows (7,8,8.1,10) and Linux(14.04 LTS) machines using latest Chrome Canary build# 69.0.3481.0 and fix is working as expected.. Hence adding TE-Verified labels. 
Kindly refer attached screen cast for your reference.
Fixed_behavior.mp4
210 KB View Download
►

Sign in to add a comment