views_unittests failing on multiple builders |
|||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of sdefresne@google.com views_unittests failing on multiple builders Builders failed on: - Mac10.11 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests - Mac10.12 Tests: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests
,
Jul 3
,
Jul 3
,
Jul 6
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725947f86744da7eed4a28b760a6ae51d56e2a9e commit 725947f86744da7eed4a28b760a6ae51d56e2a9e Author: Sidney San Martín <sdy@chromium.org> Date: Tue Jul 10 21:45:18 2018 Reland "Make all MacViews windows potentially draggable." This is a reland of 330fc4a13c739591b9a1cf438b6b82a8e8cde96d with some changes: - |[super mouseDown:]| is called from each subclass rather than the shared NSView category, so that it uses the direct superclass implementation instead of NSResponder :/. - If a mouse event would result in a resize, don't start a drag. I verified that this method exists back to 10.9. NSThemeFrame does this check, too, when movableByWindowBackground is set on its window, but it's missing from the frame view class which borderless windows use. For simplicity, I'm using the workaround for both. - Our theme frame subclasses override -usesCustomDrawing to return NO to avoid AppKit breakage (like the title not redrawing when it should). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} Bug: 849983 , 844417 , 859820 , 859829 Change-Id: I3e596bed04312617edf658e0e652e1491374b9aa Reviewed-on: https://chromium-review.googlesource.com/1125099 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573926} [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.h [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.mm
,
Jul 11
This should be all set. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Jul 3