New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 859825 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 5
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 839421
issue 851433



Sign in to add a comment

Consents datatype disabled by "Sync Everything" switch.

Project Member Reported by vitaliii@chromium.org, Jul 3

Issue description

On ToT, when I just disable "Sync Everything" switch without disabling any per datatype switches, this already disables the new datatype.
 
When I enable "Sync Everything", then the new datatype works.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08c03bc5dc5c4be0d116bbc3aaa6d8a1b582b259

commit 08c03bc5dc5c4be0d116bbc3aaa6d8a1b582b259
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Jul 04 12:29:45 2018

[Sync] Enable consents when sync is enabled.

Previously "Sync Everything" settings switch disabled user consents
datatype. In this CL, the datatype is always enabled (like device info).

Bug:  859825 
Change-Id: I345465be97d8b2d95c503130bb2e1274a96f48e1
Reviewed-on: https://chromium-review.googlesource.com/1124330
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572542}
[modify] https://crrev.com/08c03bc5dc5c4be0d116bbc3aaa6d8a1b582b259/components/sync/base/model_type.h
[modify] https://crrev.com/08c03bc5dc5c4be0d116bbc3aaa6d8a1b582b259/components/sync/base/sync_prefs.cc
[modify] https://crrev.com/08c03bc5dc5c4be0d116bbc3aaa6d8a1b582b259/components/sync/base/sync_prefs_unittest.cc

Status: Fixed (was: Started)
Checked on ToT (disabled all switches in sync settings).

Sign in to add a comment