Issue metadata
Sign in to add a comment
|
Regression: Input method icons are seen faded in the input menu on shelf |
||||||||||||||||||||||
Issue descriptionChrome Version:69.0.3479.0/10840.0.0 dev channel Candy, Blaze & Peppy OS: Chrome OS What steps will reproduce the problem? (1)Sign into user >>Open chrome://settings/languages >>Input method (2)Turn On the toggle button of 'Show input options in the shelf' (3)Click on Input methods and observe Actual: Input method icons are seen faded(Ex: US,GB..) Expected: Input method icons should be visible clear This is a Regression issue as same is working fine in 69.0.3476.0/10832.0.0 dev Note: Issue is not applicable to Linux,Windows OS Attached the screencast for reference..
,
Jul 9
Issue 860140 has been merged into this issue.
,
Jul 11
Over to azurewei@ to fix. Lan, note that the M69 branch point will be on July 19.
,
Jul 11
This is my regression so I'm going to fix it. Sorry about this.
,
Jul 19
https://crrev.com/c/1143110 Branch cut is today, but this WAI when UnifiedSystemTray is disabled, and UnifiedSystemTray will not launch in M69 so no need to merge.
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/486ece6ba7be4cfe7272ec37a6f9d59c52f0d317 commit 486ece6ba7be4cfe7272ec37a6f9d59c52f0d317 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Jul 20 05:23:15 2018 Fixed input method icon color in IME tray. Input method icon color was affected by UnifiedSystemTray flag. TEST=manual BUG= 859824 Change-Id: Id004e2bfe7e0f9addbc02385cd829b2b278eee6b Reviewed-on: https://chromium-review.googlesource.com/1143110 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#576788} [modify] https://crrev.com/486ece6ba7be4cfe7272ec37a6f9d59c52f0d317/ash/system/ime_menu/ime_list_view.cc
,
Jul 20
,
Aug 1
Reopening this for merging to R69.
,
Aug 1
,
Aug 1
This is M70 feature and the feature flag was disabled on M69 just now, there's no need to merge.
,
Aug 1
Sorry I was informed by wuyingbing@ who was seeing the faded icons on R69. Yingbing, can you please confirm? Thanks.
,
Aug 1
This is regression bug, not new feature. It does not depend on UnifiedSystemTray. The language menus already released several milestones ago. Please merge back M69.
,
Aug 1
Sorry I was not clear about that. This is not a new feature but a bug affected by a new feature flag, which is now disabled on M69. M69 beta will not have this bug without any action.
,
Aug 1
Ah, I see. Yingbing, can you please try M69 beta and confirm? Thanks.
,
Aug 1
M69 current is on dev Channel. And the bug repro.
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7
Verified in 69.0.3497.25
,
Aug 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rvera@chromium.org
, Jul 9Status: Assigned (was: Untriaged)