New issue
Advanced search Search tips

Issue 859821 link

Starred by 2 users
Status: Verified
Owner:
pbos@chromium.org
Closed: Jul 10
Cc:
bsep@chromium.org
kylixrd@chromium.org
lgrey@chromium.org
markchang@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[MdRefresh]: Extension drag line is seen attached to extension icon in toolbar

Project Member Reported by sindhu.chelamcherla@chromium.org, Jul 3 
Chrome Version: 69.0.3480.0
OS: Debian, Windows 10, Mac 10.13.3

What steps will reproduce the problem?
(1)Add any extension, try dragging that extension and observe divider line  

Expected: There should be little space between extension icon and divider line.
Actual: Instead line is seen attached to extension icon

NOTE:
1. This issue is not seen in M-68 beta.
2. Issue is not seen on setting #top-chrome-md flag to normal
Extension toolbar icon divider.png
57.5 KB View Download

Comment 1 by kylixrd@chromium.org, Jul 3

Cc: markchang@chromium.org bsep@chromium.org kylixrd@chromium.org pkasting@chromium.org
Owner: pbos@chromium.org

Comment 2 by robliao@chromium.org, Jul 3

Labels: -Pri-2 Pri-1
Triage: Promoting to P1.

Comment 3 by pbos@chromium.org, Jul 3

Cc: pbos@chromium.org
Owner: lgrey@chromium.org
lgrey@: I think this is covered by your issue 826865. Should we just dedup against that one?

Comment 4 by lgrey@chromium.org, Jul 3 

If it's P1 probably not, since I'm not sure the issue 826865 will make M69

Comment 5 by pbos@chromium.org, Jul 3

Cc: -pbos@chromium.org lgrey@chromium.org
Owner: pbos@chromium.org
Ok, thanks! I'll see if I can get a band-aid in there for M69 then.

Comment 6 by pbos@chromium.org, Jul 3

Cc: pbos@chromium.org
Owner: bsep@chromium.org
Load balancing.

Comment 7 by bsep@chromium.org, Jul 9

Cc: -pbos@chromium.org
Owner: pbos@chromium.org
Load balancing again
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5d9c0af79dadce7979eec82780c840bf5583ed8

commit f5d9c0af79dadce7979eec82780c840bf5583ed8
Author: Peter Boström <pbos@chromium.org>
Date: Tue Jul 10 00:50:26 2018

Align BrowserActionsContainer drag/drop

Fixes regression after a resize area was not accounted for when
calculating drag/drop positions and the visible marker.

This is a symptom of view placement being calculated separately from
drag-drop-marker placement. This should be easier to unify when after
MacViews when BrowserActionsContainer and ToolbarActionsBar can merge.

Bug:  chromium:859821 
Change-Id: Ia6295fa4883aab8bbabaa778bdbd2dd379df9d2e
Reviewed-on: https://chromium-review.googlesource.com/1130539
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573567}
[modify] https://crrev.com/f5d9c0af79dadce7979eec82780c840bf5583ed8/chrome/browser/ui/views/toolbar/browser_actions_container.cc

Comment 9 by pbos@chromium.org, Jul 10

Status: Fixed (was: Assigned)

Comment 10 by sindhu.chelamcherla@chromium.org, Jul 10

Labels: TE-Verified-69.0.3487.0 TE-Verified-M69
Able to reproduce this issue on reported version hence verifying the fix on latest canary 69.0.3487.0 using Windows 10, Mac 10.13.3 and Debian.

Now Observing spacing between extension icon and drag line. Attaching screencast for reference.

As fix is working as expected adding TE-Verified labels.
859821_M-69.mp4
829 KB View Download

Comment 11 by pbos@chromium.org, Jul 10

Status: Verified (was: Fixed)
Thanks!
►

Sign in to add a comment