Issue metadata
Sign in to add a comment
|
Regression: [MAC]Unable to resize the browser after enabling MacViews flags.
Reported by
aiman.an...@etouch.net,
Jul 3
|
||||||||||||||||||||||
Issue descriptionChrome Version : 69.0.3480.0 (Official Build) 3c4342c43a5e8e33042613038d4777cc1c9349af-refs/branch-heads/3480@{#1} 64 bit OS: Mac(10.12.6, 10.13.1, 10.13.6, 10.14). Pre-Condiiton: Enable 'Use Views browser windows instead of Cocoa' flag from chrome://flags and relaunch the browser. Steps to reproduce: 1. Launch chrome, Open NTP and try to resize browser. Actual Result: Unable to resize the browser after enabling MacViews flags. Expected Result: resize the browser.Should be able to This is a regression issue, broken in 'M-69', and below is the bisect provided using per-revision script. Good Build:69.0.3479.0 (Revision: 571804) Bad Build: 69.0.3480.0 (Revision: 572081) You are probably looking for a change made after 572037 (known good), but no later than 572038 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/c3743d1589d2d410d315da1e72fd61f9f85456fc..330fc4a13c739591b9a1cf438b6b82a8e8cde96d Suspect: https://chromium.googlesource.com/chromium/src/+/330fc4a13c739591b9a1cf438b6b82a8e8cde96d sdy@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Note: Issue is Mac specific and is not reproducible on Windows(7,8,8.1,10) and Linux(14.04 LTS). Kindly refer the screen-cast using the below given link. https://drive.google.com/drive/folders/1bgs1sQRqRkAObcTbKJiCMf4ocpeWqzSu?usp=sharing Thank You.
,
Jul 3
,
Jul 3
,
Jul 3
The offending commit was reverted: 07c50437949bbc21dcf3b5f24046fa63ffb4635c.
,
Jul 3
sdy@, thank you for the quick revert.
,
Jul 3
Thank sdefresne@ :-).
,
Jul 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/725947f86744da7eed4a28b760a6ae51d56e2a9e commit 725947f86744da7eed4a28b760a6ae51d56e2a9e Author: Sidney San Martín <sdy@chromium.org> Date: Tue Jul 10 21:45:18 2018 Reland "Make all MacViews windows potentially draggable." This is a reland of 330fc4a13c739591b9a1cf438b6b82a8e8cde96d with some changes: - |[super mouseDown:]| is called from each subclass rather than the shared NSView category, so that it uses the direct superclass implementation instead of NSResponder :/. - If a mouse event would result in a resize, don't start a drag. I verified that this method exists back to 10.9. NSThemeFrame does this check, too, when movableByWindowBackground is set on its window, but it's missing from the frame view class which borderless windows use. For simplicity, I'm using the workaround for both. - Our theme frame subclasses override -usesCustomDrawing to return NO to avoid AppKit breakage (like the title not redrawing when it should). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} Bug: 849983 , 844417 , 859820 , 859829 Change-Id: I3e596bed04312617edf658e0e652e1491374b9aa Reviewed-on: https://chromium-review.googlesource.com/1125099 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573926} [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/browser_native_widget_window_mac.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/chrome/browser/ui/views/frame/native_widget_mac_frameless_nswindow.mm [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.h [modify] https://crrev.com/725947f86744da7eed4a28b760a6ae51d56e2a9e/ui/views/cocoa/native_widget_mac_nswindow.mm
,
Jul 11
Hi, Retested the above issue on Mac(10.12.6, 10.13.1, 10.13.6, 10.14) OS using latest Canary build #69.0.3488.0 and issue is fixed now. Able to resize the browser after enabling Mac-Views flag. Kindly refer the attached screen-cast for reference. Thank You!
,
Jul 11
thanks for verifying :) |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jul 3Labels: ReleaseBlock-Stable