New issue
Advanced search Search tips

Issue 859811 link

Starred by 1 user
Status: Fixed
Owner:
gambard@chromium.org
Closed: Jul 10
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

When opening the popup menu with long press, releasing on the menu should activate the item

Project Member Reported by gambard@chromium.org, Jul 3 
When the user opens a toolbar's button popup menu by long pressing it, the user should be able to slide the finger, without releasing it, on a menu item. At this point, releasing the hold should activate the menu item.

This is the same thing as what is available on force touch on the home screen.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d

commit b1d8ae6ab5d4dda1c999c16b34acd82769cda61d
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue Jul 10 07:25:29 2018

[iOS] Add swipe-to-select feature to popup menu

This CL adds a feature to allow the user to select an entry in the popup
menu without lift the finger triggering the long press.
Moving the finger from the button triggering the popup menu to a popup
menu's row without releasing the press allow a selection.

Bug:  859811 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I2f4600e8be8eb2f7d0b3da346cacfeadecb44af6
Reviewed-on: https://chromium-review.googlesource.com/1124681
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573641}
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/BUILD.gn
[add] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_consumer.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_coordinator.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/popup_menu_table_view_controller.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/public/BUILD.gn
[add] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/popup_menu/public/popup_menu_long_press_delegate.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/tabs/BUILD.gn
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/tabs/tab_strip_controller.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/tabs/tab_strip_controller.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/tabs/tab_strip_legacy_coordinator.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/tabs/tab_strip_legacy_coordinator.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.h
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_view_controller.mm
[modify] https://crrev.com/b1d8ae6ab5d4dda1c999c16b34acd82769cda61d/tools/metrics/actions/actions.xml

Comment 2 by gambard@chromium.org, Jul 10

Labels: -Pri-3 Pri-1
Status: Fixed (was: Assigned)

Comment 3 by rakurati@chromium.org, Jul 17

Status: Verified (was: Fixed)
Verified in 69.0.3494.0 canary in iPhone X(iOS 11.4.1), iPad Air(iOS 11.4) and iPhone 7plus(iOS 10.3.3)

Long press and release on the menu will activate the items

Link to video:
https://drive.google.com/file/d/1FujgBH5oyGjvHl_2e0WluYCje1ubXsqC/view?usp=sharing

Comment 4 by rakurati@chromium.org, Jul 17

Status: Fixed (was: Verified)
►

Sign in to add a comment